Skip to content

Add missing message-id to step which modifies PR comment #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 3, 2025

message-id was added per #2271 to mshick/add-pr-comment steps in GitHub workflows, but one of the places was missing.

The PR proposes to resolve that and to set the expected id, otherwise the affected step couldn't find the PR comment to update it (since message-id: add-pr-comment which it built by default differs).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 3, 2025
@antonwolfy antonwolfy changed the title Add missing message-id to step which modifies PR comment Add missing message-id to step which modifies PR comment Feb 3, 2025
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

Copy link
Contributor

github-actions bot commented Feb 3, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.325%. remained the same
when pulling d959440 on add-missing-message-id
into eb3542c on master.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_16 ran successfully.
Passed: 968
Failed: 0
Skipped: 32

@antonwolfy antonwolfy merged commit 2ac196c into master Feb 3, 2025
66 of 71 checks passed
@antonwolfy antonwolfy deleted the add-missing-message-id branch February 3, 2025 16:07
github-actions bot added a commit that referenced this pull request Feb 3, 2025
`message-id` was added per #2271 to `mshick/add-pr-comment` steps in
GitHub workflows, but one of the places was missing.

The PR proposes to resolve that and to set the expected id, otherwise
the affected step couldn't find the PR comment to update it (since
`message-id: add-pr-comment` which it built by default differs). 2ac196c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants