Skip to content

implement dpnp.hamming #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 27, 2025
Merged

implement dpnp.hamming #2341

merged 10 commits into from
Feb 27, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 25, 2025

In this PR, dpnp.hamming is implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 25, 2025 •
edited
Loading

Coverage Status

coverage: 71.917% (+0.03%) from 71.883%
when pulling 6847e32 on impl-hamming
into d57ac14 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_17 ran successfully.
Passed: 1006
Failed: 0
Skipped: 16

@vtavana vtavana marked this pull request as ready for review February 25, 2025 20:07
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Feb 26, 2025
antonwolfy
antonwolfy reviewed Feb 27, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few more minor comments, but in overall LGTM. Thank you @vtavana for implementing that windows function.

@vtavana vtavana merged commit 2bb1e8b into master Feb 27, 2025
65 of 67 checks passed
@vtavana vtavana deleted the impl-hamming branch February 27, 2025 22:34
github-actions bot added a commit that referenced this pull request Feb 27, 2025
@github-actions
implement dpnp.hamming (#2341)
e9da2d9 
In this PR, `dpnp.hamming` is implemented. 2bb1e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy