Skip to content

Update docstrings for linalg functions #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

Update docstrings for linalg functions #2373

merged 2 commits into from
Mar 19, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 19, 2025 •
edited
Loading

The PR updates docstrings for linalg functions to have a blank line prior Default value.
Additionally, it adds a space after comma to align with used code style.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.763%. remained the same
when pulling 3f7ec15 on update-linalg-docstrings
into c2f0735 on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_34 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@antonwolfy antonwolfy merged commit 764f92c into master Mar 19, 2025
68 checks passed
@antonwolfy antonwolfy deleted the update-linalg-docstrings branch March 19, 2025 16:00
github-actions bot added a commit that referenced this pull request Mar 19, 2025
@github-actions
Update docstrings for linalg functions (#2373)
33a657a 
The PR updates docstrings for linalg functions to have a blank line
prior `Default` value.
Additionally, it adds a space after comma to align with used code style. 764f92c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana