Skip to content

add support for order=None in dpnp.einsum #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

add support for order=None in dpnp.einsum #2411

merged 2 commits into from
Apr 9, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 8, 2025 •
edited
Loading

Add support for order=None for dpnp.einsum

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.271%. remained the same
when pulling 266a0f8 on einsum-order
into 9b1f5be on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_71 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

@vtavana vtavana marked this pull request as ready for review April 8, 2025 15:39
antonwolfy
antonwolfy approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana , LGTM

@vtavana vtavana merged commit 43095fb into master Apr 9, 2025
60 of 68 checks passed
@vtavana vtavana deleted the einsum-order branch April 9, 2025 13:16
github-actions bot added a commit that referenced this pull request Apr 9, 2025
@github-actions
add support for order=None in dpnp.einsum (#2411)
4f75a2d 
Add support for `order=None` for `dpnp.einsum` 43095fb
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy