Fixes bug in boxing a DpnpNdArray from parent. #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
fix/boxing_dpnpndarray_from_parent
branch
2 times, most recently
from
592ea61 to
a81927d
Compare
- When boxing a dpnp.ndarray using the reference of the parent
stored during unboxing, there is a validation step on the strides.
However, as a dpnp.ndarray object does not store any stride
information when an array is unit strided the strides need to be
calculated and validated against the strides in the Numba
usmarraystruct object.
The PR fixes the stride calculation that was previously done
incorrectly.
diptorupd
force-pushed
the
fix/boxing_dpnpndarray_from_parent
branch
from
a81927d to
10a8028
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2023
…_parent Fixes bug in boxing a DpnpNdArray from parent. 39b5a5c
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
…_parent Fixes bug in boxing a DpnpNdArray from parent. 39b5a5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boxing a dpnp.ndarray using the reference of the parent
stored during unboxing, there is a validation step on the strides.
However, as a dpnp.ndarray object does not store any stride
information when an array is unit strided the strides need to be
calculated and validated against the strides in the Numba
usmarraystruct object.
The PR fixes the stride calculation that was previously done
incorrectly.