-
Notifications
You must be signed in to change notification settings - Fork 4
Readme update #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme update #37
Conversation
README.md
Outdated
A quick usage example can be found in the `example/` directory and under example.php. | ||
A quick usage example can be found in the `example/` directory and under example.php. Included is a light theme and a dark theme. | ||
|
||
<details><summery>Example Pictures</summery><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the <summary>
tags.
README.md
Outdated
@@ -25,6 +25,8 @@ composer require jblond/php-diff | |||
|
|||
## Example Use | |||
|
|||
<details><summery> </summery><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the <summary>
tags.
Are you sure you want the content to be a non breaking space instead of a description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I guess it didn't work in the first place because of the typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some inline remarks.
I'm not sure the details/summary tags are widely used, but make sure the readers will understand a click on the element will open/close a block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be the <br>
tags at line 28 and 71 are redundant.
But they don't hurt anyway.
No description provided.