Skip to content

Commit 76df582

Browse files
committed
Temporarily fix a test: TestVSCode
Summary: This is to temporarily fix the test `TestVSCode`, before [PR llvm#97004](llvm#97004) can be upstreamed and pulled into `toolchain/llvm-sand/main`. The bug was that a previous PR ([llvm#95075](llvm#95075)) accidentally removed the `targets` section from `statistics dump --summary`, which this test relies on. The fix in [PR llvm#97004](llvm#97004) reverts that behavior, while the temporary fix in this diff just explicitly adds an option to make sure that the `targets` section is generated. This diff *can (but doesn't have to)* be reverted after [PR llvm#97004](llvm#97004) has been merged and pulled into `llvm-sand`. Test Plan: Manually tested after applying this diff on top of the release candidate that I'm working on. Reviewers: jeffreytan, #lldb_team Subscribers: gclayton, #lldb_team Differential Revision: https://phabricator.intern.facebook.com/D59139567
1 parent b6969e4 commit 76df582

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lldb/tools/lldb-dap/JSONUtils.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,6 +1527,11 @@ static void FilterAndGetValueForKey(const lldb::SBStructuredData data,
15271527
void addStatisticsSummary(lldb::SBTarget &target, llvm::json::Object &event) {
15281528
lldb::SBStatisticsOptions options;
15291529
options.SetSummaryOnly(true);
1530+
// META BEGIN
1531+
// Temporary fix until #97004 is upstreamed.
1532+
// TODO: Revert/delete this block once #97004 is in toolchain/llvm-sand/main
1533+
options.SetIncludeTargets(true);
1534+
// META END
15301535
lldb::SBStructuredData statistics = target.GetStatistics(options);
15311536

15321537
bool is_dictionary =

0 commit comments

Comments
 (0)