Minor updates to compile cppfront and the new test cleanly using MSVC

And re-remove a few stray `;` that were removed as part of PR hsutter#911 and now cause errors because of the pedantic builds

I regenerated `reflect.h` and found two changes that weren't already in the PR, so committing those too

Also including the new test file's run against MSVC showing the five messages mentioned in the PR review, see PR review for more...

Author: hsutter

regression-tests/test-results/msvc-2022/pure2-last-use.cpp.output

@@ -0,0 +1,9 @@
+pure2-last-use.cpp
+pure2-last-use.cpp2(193): error C3889: call to object of class type 'issue_857::o2::<lambda_1>': no matching call operator found
+pure2-last-use.cpp2(193): note: could be 'decltype(auto) issue_857::o2::<lambda_1>::operator ()(Obj &&,Params &&...) noexcept(<expr>) const'
+pure2-last-use.cpp2(193): note: the associated constraints are not satisfied
+pure2-last-use.cpp2(193): note: the constraint was not satisfied
+pure2-last-use.cpp2(314): warning C4552: '+': result of expression not used
+pure2-last-use.cpp2(315): warning C4552: '+': result of expression not used
+pure2-last-use.cpp2(316): warning C4552: '+': result of expression not used
+pure2-last-use.cpp2(317): warning C4552: '+': result of expression not used

source/common.h

@@ -12,7 +12,7 @@
 
 
 #ifdef _MSC_VER
-#pragma warning(disable: 4456)
+#pragma warning(disable: 4456 4706)
 #endif
 
 #include "cpp2util.h"
@@ -334,7 +334,7 @@ auto is_nondigit(char c)
         isalpha(c)
         || c == '_'
         ;
-};
+}
 
 //G identifier-start:
 //G     nondigit
@@ -379,7 +379,7 @@ auto starts_with_identifier(std::string_view s)
         return j;
     }
     return 0;
-};
+}
 
 
 //  Helper to allow one of the above or a digit separator

source/lex.h

@@ -199,7 +199,7 @@ auto _as(lexeme l)
     break;case lexeme::None:                return "(NONE)";
     break;default:                          return "INTERNAL-ERROR";
     }
-};
+}
 
 
 auto is_operator(lexeme l)

source/reflect.h

@@ -1352,7 +1352,7 @@ auto ordered_impl(
         if (CPP2_UFCS(has_name)(mf, "operator<=>")) {
             has_spaceship = true;
             auto return_name {CPP2_UFCS(unnamed_return_type)(mf)}; 
-            if (CPP2_UFCS(find)(return_name, ordering) == std::move(return_name).npos) 
+            if (CPP2_UFCS(find)(return_name, ordering) == return_name.npos) 
             {
                 CPP2_UFCS(error)(mf, "operator<=> must return std::" + cpp2::as_<std::string>(ordering));
             }
@@ -1951,7 +1951,7 @@ auto print(cpp2::in<meta::type_declaration> t) -> void
             && !(CPP2_UFCS(arguments_were_used)(rtype)))) 
 
         {
-            error(name + " did not use its template arguments - did you mean to write '" + std::move(name) + " <" + CPP2_ASSERT_IN_BOUNDS(std::move(args), 0) + "> type' (with the spaces)?");
+            error(name + " did not use its template arguments - did you mean to write '" + name + " <" + CPP2_ASSERT_IN_BOUNDS(std::move(args), 0) + "> type' (with the spaces)?");
             return false; 
         }
     }

source/sema.h

@@ -2032,7 +2032,10 @@ class sema
 
     auto push(std::vector<std::pair<int, int>>& uses) -> void
     {
-        uses.emplace_back(std::ssize(indices_of_uses_per_scope) - 1, std::ssize(indices_of_uses_per_scope.back()));
+        uses.emplace_back(
+            unsafe_narrow<int>(std::ssize(indices_of_uses_per_scope) - 1),
+            unsafe_narrow<int>(std::ssize(indices_of_uses_per_scope.back()))
+        );
     }
 
     auto get(std::vector<std::pair<int, int>>& uses) -> std::span<const int>