char to symbol in Symmetric/HermitianOperator convert (#501)

Author: jishnub

src/Operators/general/OperatorLayout.jl

@@ -1,15 +1,24 @@
-
-
 export HermitianOperator, SymmetricOperator, AdjointOperator, TransposeOperator
 
+function char_to_symbol(uplo::Char)
+    if uplo == 'U'
+        return :U
+    elseif uplo == 'L'
+        return :L
+    else
+        throw(ArgumentError("invalid uplo $uplo"))
+    end
+end
 
 struct HermitianOperator{T<:Number,B<:Operator} <: Operator{T}
     op::B
     uplo::Char
 end
 
 HermitianOperator(B::Operator{T}, uplo::Symbol=:U) where {T<:Number} = HermitianOperator{T,typeof(B)}(B, char_uplo(uplo))
-convert(::Type{Operator{T}},A::HermitianOperator) where {T}=HermitianOperator(strictconvert(Operator{T},A.op), A.uplo)
+function convert(::Type{Operator{T}},A::HermitianOperator) where {T}
+    HermitianOperator(strictconvert(Operator{T},A.op), char_to_symbol(A.uplo))
+end
 
 domainspace(P::HermitianOperator)=domainspace(P.op)
 rangespace(P::HermitianOperator)=rangespace(P.op)
@@ -42,7 +51,9 @@ struct SymmetricOperator{T<:Number,B<:Operator} <: Operator{T}
 end
 
 SymmetricOperator(B::Operator{T}, uplo::Symbol=:U) where {T<:Number} = SymmetricOperator{T,typeof(B)}(B, char_uplo(uplo))
-convert(::Type{Operator{T}},A::SymmetricOperator) where {T}=SymmetricOperator(strictconvert(Operator{T},A.op), A.uplo)
+function convert(::Type{Operator{T}},A::SymmetricOperator) where {T}
+    SymmetricOperator(strictconvert(Operator{T},A.op), char_to_symbol(A.uplo))
+end
 
 domainspace(P::SymmetricOperator)=domainspace(P.op)
 rangespace(P::SymmetricOperator)=rangespace(P.op)

test/PolynomialSpacesTests.jl

@@ -326,6 +326,17 @@ Base.:(==)(a::UniqueInterval, b::UniqueInterval) = (@assert a.parentinterval ==
         end
     end
 
+    @testset "layout Operators" begin
+        D = Derivative(Chebyshev())
+        for S in (SymmetricOperator(D),
+                    HermitianOperator(D))
+            S2 = convert(Operator{Int}, S)
+            B = S2[1:10, 1:10]
+            @test B isa BandedMatrix{Int}
+            @test S2[1:10, 1:10] == S[1:10, 1:10]
+        end
+    end
+
     @testset "inplace ldiv" begin
         @testset for T in [Float32, Float64, ComplexF32, ComplexF64]
             v = rand(T, 4)