fixes to ProductFun (#217)

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunBase"
 uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
-version = "0.7.11"
+version = "0.7.12"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Multivariate/ProductFun.jl

@@ -37,9 +37,9 @@ end
 
 ## Construction in a ProductSpace via a Vector of Funs
 
-function ProductFun(M::Vector{VFun{S,T}},dy::V) where {S<:UnivariateSpace,V<:UnivariateSpace,T<:Number}
-    funs=VFun{S,T}[Mk for Mk in M]
-    ProductFun{S,V,ProductSpace{S,V},T}(funs,ProductSpace(S[space(fun) for fun in funs],dy))
+function ProductFun(M::AbstractVector{VFun{S,T}},dy::V) where {S<:UnivariateSpace,V<:UnivariateSpace,T<:Number}
+    prodsp = ProductSpace(map(space, M), dy)
+    ProductFun{S,V,typeof(prodsp),T}(copy(M), prodsp)
 end
 
 ## Adaptive construction

src/Multivariate/TensorSpace.jl

@@ -307,14 +307,16 @@ struct ProductSpace{S<:Space,V<:Space,D,R} <: AbstractProductSpace{Tuple{S,V},D,
     spacey::V
 end
 
-ProductSpace(spacesx::Vector,spacey) =
-    ProductSpace{eltype(spacesx),typeof(spacey),typeof(mapreduce(domain,×,sp)),
-                mapreduce(s->eltype(domain(s)),promote_type,sp)}(spacesx,spacey)
+function ProductSpace(spacesx::AbstractVector, spacey)
+    ProductSpace{eltype(spacesx),typeof(spacey),typeof(mapreduce(domain, ×, spacesx)),
+                mapreduce(s->eltype(domain(s)),promote_type,spacesx)}(spacesx,spacey)
+end
 
 # TODO: This is a weird definition
-⊗(A::Vector{S},B::Space) where {S<:Space} = ProductSpace(A,B)
-domain(f::ProductSpace) = domain(f.spacesx[1])×domain(f.spacesy)
+⊗(A::AbstractVector{S},B::Space) where {S<:Space} = ProductSpace(A,B)
+domain(f::ProductSpace) = domain(f.spacesx[1]) × domain(f.spacey)
 
+factors(d::ProductSpace) = (d.spacesx, d.spacey)
 
 nfactors(d::AbstractProductSpace) = length(d.spaces)
 factors(d::AbstractProductSpace) = d.spaces

src/show.jl

@@ -25,7 +25,7 @@ function show(io::IO,L::LowRankFun)
 end
 
 function show(io::IO,P::ProductFun)
-    print(io,"ProductFun on ",space(P),".")
+    print(io,"ProductFun on ",space(P))
 end
 
 ## Operator