Skip to content

Commit bd77b87

Browse files
authored
AbstractVector points in findapproxmaxvector and friends (#391)
* AbstractVector points in findapproxmax and friends * version bump to v0.8.2
1 parent 3f62b15 commit bd77b87

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "ApproxFunBase"
22
uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
3-
version = "0.8.1"
3+
version = "0.8.2"
44

55
[deps]
66
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Multivariate/LowRankFun.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ LowRankFun(f::LowRankFun) = LowRankFun(f,ChebyshevInterval(),ChebyshevInterval()
247247

248248
## Utilities
249249

250-
function findapproxmax!(f::Function,X::AbstractMatrix,ptsx::AbstractVector,ptsy::Vector,gridx,gridy)
250+
function findapproxmax!(f::Function,X::AbstractMatrix,ptsx::AbstractVector,ptsy::AbstractVector,gridx,gridy)
251251
for j=1:gridy
252252
ptsyj = ptsy[j]
253253
@simd for k=1:gridx
@@ -259,23 +259,23 @@ function findapproxmax!(f::Function,X::AbstractMatrix,ptsx::AbstractVector,ptsy:
259259
maxabsf,[ptsx[imptple[1]],ptsy[imptple[2]]]
260260
end
261261

262-
function findapproxmax!(A::Fun,B::Fun,X::AbstractMatrix,ptsx::Vector,ptsy::Vector,gridx,gridy)
262+
function findapproxmax!(A::Fun,B::Fun,X::AbstractMatrix,ptsx::AbstractVector,ptsy::AbstractVector,gridx,gridy)
263263
Ax,By = A.(ptsx),B.(ptsy)
264264
subtractrankone!(Ax,By,X,gridx,gridy)
265265
maxabsf,impt = findmaxabs(X)
266266
imptple = CartesianIndices((gridx,gridy))[impt]
267267
[ptsx[imptple[1]],ptsy[imptple[2]]]
268268
end
269269

270-
function findcholeskyapproxmax!(f::Function,X::AbstractVector,pts::Vector,grid)
270+
function findcholeskyapproxmax!(f::Function,X::AbstractVector,pts::AbstractVector,grid)
271271
@simd for k=1:grid
272272
@inbounds X[k]+=f(pts[k],pts[k])
273273
end
274274
maxabsf,impt = findmaxabs(X)
275275
maxabsf,pts[impt]
276276
end
277277

278-
function findcholeskyapproxmax!(A::Fun,B::Fun,X::Vector,pts::Vector,grid)
278+
function findcholeskyapproxmax!(A::Fun,B::Fun,X::AbstractVector,pts::AbstractVector,grid)
279279
Ax,By = A.(pts),B.(pts)
280280
subtractrankone!(Ax,By,X,grid)
281281
maxabsf,impt = findmaxabs(X)

0 commit comments

Comments
 (0)