TensorSpace in ProductFun constructor (#541)

* TensorSpace in ProductFun constructor

* Promote to maxspace

Author: jishnub

src/Multivariate/ProductFun.jl

@@ -109,8 +109,10 @@ true
 ```
 """
 function ProductFun(M::AbstractVector{VFun{S,T}}, dy::V) where {S<:UnivariateSpace,V<:UnivariateSpace,T<:Number}
-    prodsp = ProductSpace(map(space, M), dy)
-    ProductFun{S,V,typeof(prodsp),T}(copy(M), prodsp)
+    sp = mapreduce(space, maxspace, M)
+    Msp = [Fun(f, sp) for f in M]
+    prodsp = sp ⊗ dy
+    ProductFun{S,V,typeof(prodsp),T}(Msp, prodsp)
 end
 
 ## Adaptive construction

src/Multivariate/TensorSpace.jl

@@ -435,6 +435,8 @@ domain(f::ProductSpace) = f.domain
 
 factors(d::ProductSpace) = (d.spacesx, d.spacey)
 
+show(io::IO, P::ProductSpace) = print(io, "ProductSpace", factors(P))
+
 ## Transforms
 function nDtransform_inner!(A, tempv, Rpre, Rpost, dim, plan!)
     for indpost in Rpost, indpre in Rpre

test/show.jl

@@ -11,7 +11,7 @@
 		@testset "ConstantSpace" begin
 			@test contains(repr(ConstantSpace()), "ConstantSpace")
 			c = ConstantSpace(0..1)
-			@test contains(repr(c), "ConstantSpace")
+			@test startswith(repr(c), "ConstantSpace")
 			@test contains(repr(c), repr(domain(c)))
 		end
 		@testset "TensorSpace" begin
@@ -21,6 +21,13 @@
 			@test length(v) == 2
 			@test all(==(repr(S1)), v)
 		end
+		@testset "ProductSpace" begin
+			S1 = PointSpace(1:4)
+			S2 = PointSpace(1:2)
+			P = ProductSpace([S1, S1], S2)
+			@test startswith(repr(P), "ProductSpace")
+			@test contains(repr(P), string(factors(P)))
+		end
 		@testset "SumSpace" begin
 			S1 = PointSpace(1:3)
 			S = S1 ⊕ S1
@@ -32,7 +39,7 @@
 			p = PointSpace(1:4)
 			ps = PiecewiseSpace(p)
 			rpr = repr(ps)
-			@test contains(rpr, "PiecewiseSpace")
+			@test startswith(rpr, "PiecewiseSpace")
 			@test contains(rpr, repr(p))
 		end
 	end