Domainspace in normalized space multiplication (#173)

* domainspace in normalizedspace multiplication

* Add test

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunOrthogonalPolynomials"
 uuid = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
-version = "0.6.3"
+version = "0.6.4"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
@@ -20,7 +20,7 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
-ApproxFunBase = "0.7.58"
+ApproxFunBase = "0.7.59"
 ApproxFunBaseTest = "0.1"
 Aqua = "0.5"
 BandedMatrices = "0.16, 0.17"

src/Spaces/PolynomialSpace.jl

@@ -457,15 +457,14 @@ hasconversion(a::NormalizedPolynomialSpace,b::PolynomialSpace) = hasconversion(a
 hasconversion(a::NormalizedPolynomialSpace,b::NormalizedPolynomialSpace) = hasconversion(a.space,b)
 
 
-function Multiplication(f::Fun{U},sp::NormalizedPolynomialSpace) where U <: PolynomialSpace
-    fsp = space(f)
-    unnorm_sp = sp.space
+function Multiplication(f::Fun{<:PolynomialSpace}, sp::NormalizedPolynomialSpace)
+    unnorm_sp = canonicalspace(sp)
     O = Conversion(unnorm_sp,sp) *
             Multiplication(f,unnorm_sp) * Conversion(sp, unnorm_sp)
-    MultiplicationWrapper(f, O)
+    MultiplicationWrapper(f, O, sp)
 end
 
-function Multiplication(f::Fun{U},sp::PolynomialSpace) where U <: NormalizedPolynomialSpace
+function Multiplication(f::Fun{ <: NormalizedPolynomialSpace}, sp::PolynomialSpace)
     Multiplication(Conversion(space(f), canonicalspace(f))*f, sp)
 end
 

test/JacobiTest.jl

@@ -240,6 +240,11 @@ using Static
         f=Fun(exp,Jacobi(0.590,0.213))
 
         @test (g*f)(.1) ≈ cos(.1)*exp(.1)
+
+        @testset "Mutliplication in a normalized space" begin
+            M = @inferred Multiplication(Fun(Legendre()), NormalizedLegendre())
+            @test M * Fun(NormalizedLegendre()) ≈ Fun(x->x^2, NormalizedLegendre())
+        end
     end
 
     @testset "Jacobi integrate and sum" begin