Skip to content

Commit ffebcf7

Browse files
Fix method ambiguity for Normalized() \ Weighted(Normalized)) (#190)
* Fix method ambiguity * Use the variables * Update src/normalized.jl Co-authored-by: Sheehan Olver <[email protected]> --------- Co-authored-by: Sheehan Olver <[email protected]>
1 parent 761ea6f commit ffebcf7

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/normalized.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ copy(L::Ldiv{Lay,<:WeightedBasisLayout{<:AbstractNormalizedOPLayout}}) where Lay
198198
copy(L::Ldiv{<:WeightedBasisLayout{<:AbstractNormalizedOPLayout},<:WeightedBasisLayout{<:AbstractNormalizedOPLayout}}) = copy(Ldiv{ApplyLayout{typeof(*)},ApplyLayout{typeof(*)}}(L.A,L.B))
199199
copy(L::Ldiv{<:WeightedOPLayout{<:AbstractNormalizedOPLayout},<:WeightedBasisLayout{<:AbstractNormalizedOPLayout}}) = copy(Ldiv{ApplyLayout{typeof(*)},ApplyLayout{typeof(*)}}(L.A,L.B))
200200
copy(L::Ldiv{<:WeightedBasisLayout{<:AbstractNormalizedOPLayout},<:WeightedOPLayout{<:AbstractNormalizedOPLayout}}) = copy(Ldiv{ApplyLayout{typeof(*)},ApplyLayout{typeof(*)}}(L.A,L.B))
201-
201+
copy(L::Ldiv{<:AbstractNormalizedOPLayout, <:WeightedOPLayout{<:AbstractNormalizedOPLayout}}) = copy(Ldiv{ApplyLayout{typeof(*)},ApplyLayout{typeof(*)}}(L.A, L.B))
202202

203203
# function layout_broadcasted(::ExpansionLayout{WeightedOPLayout}, ::OPLayout, ::typeof(*), a, P)
204204
# axes(a,1) == axes(P,1) || throw(DimensionMismatch())

test/test_normalized.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,13 @@ import ContinuumArrays: MappedWeightedBasisLayout
169169
@test Q[0.1,1:4] [0.728237657560985,0.41715052371131806,-0.6523500049588019,-0.5607891513201705]
170170
w = JacobiWeight(1/2,0)
171171
@test (Q'*(w .* Q))[1:10,1:10] I
172+
173+
P⁰⁰ = Normalized(Jacobi(0, 0))
174+
P¹⁰ = Normalized(Jacobi(1, 0))
175+
L = Jacobi(0, 0) \ Weighted(Jacobi(1, 0))
176+
= (Diagonal(P⁰⁰.scaling) \ L) * Diagonal(P¹⁰.scaling)
177+
L2 = P⁰⁰ \ Weighted(P¹⁰)
178+
@test L2[1:100, 1:100] L̄[1:100, 1:100]
172179
end
173180

174181
@testset "Mapped" begin

0 commit comments

Comments
 (0)