Skip to content

Commit 12730b2

Browse files
committed
Always use transform_ldiv_if_columns when finite columns
1 parent f4acc53 commit 12730b2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/ContinuumArrays.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ end
7474
(unblock(A, inds, I), to_indices(A, _maybetail(inds), tail(I))...)
7575
@inline to_indices(A::AbstractQuasiArray, inds, I::Tuple{BlockIndex{1}, Vararg{Any}}) =
7676
(inds[1][I[1]], to_indices(A, _maybetail(inds), tail(I))...)
77+
@inline to_indices(A::AbstractQuasiArray, I::Tuple{BlockRange, Vararg{Any}}) = to_indices(A, axes(A), I)
7778

7879
@inline to_indices(A::AbstractQuasiArray, inds, I::Tuple{AbstractArray{<:BlockIndex{1}}, Vararg{Any}}) =
7980
(inds[1][I[1]], to_indices(A, _maybetail(inds), tail(I))...)

src/bases/bases.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,11 +265,12 @@ copy(L::Ldiv{<:AbstractBasisLayout,ApplyLayout{typeof(*)}}) = copy(Ldiv{UnknownL
265265
# A BroadcastLayout of unknown function is only knowable pointwise
266266
transform_ldiv_if_columns(A, B, _) = ApplyQuasiArray(\, A, B)
267267
transform_ldiv_if_columns(A, B, ::Base.OneTo) = transform_ldiv(A,B)
268-
copy(L::Ldiv{<:AbstractBasisLayout,<:BroadcastLayout}) = transform_ldiv_if_columns(L.A, L.B, axes(L.B,2))
268+
transform_ldiv_if_columns(A, B) = transform_ldiv_if_columns(A, B, axes(B,2))
269+
copy(L::Ldiv{<:AbstractBasisLayout,<:BroadcastLayout}) = transform_ldiv_if_columns(L.A, L.B)
269270
# Inclusion are QuasiArrayLayout
270271
copy(L::Ldiv{<:AbstractBasisLayout,QuasiArrayLayout}) = transform_ldiv(L.A, L.B)
271272
# Otherwise keep lazy to support, e.g., U\D*T
272-
copy(L::Ldiv{<:AbstractBasisLayout,<:AbstractLazyLayout}) = ApplyQuasiArray(\, L.A, L.B)
273+
copy(L::Ldiv{<:AbstractBasisLayout,<:AbstractLazyLayout}) = transform_ldiv_if_columns(L.A, L.B)
273274
copy(L::Ldiv{<:AbstractBasisLayout,ZerosLayout}) = Zeros{eltype(L)}(axes(L)...)
274275

275276
"""

0 commit comments

Comments
 (0)