better subbassis broadcastcasis

Author: dlfivefifty

src/bases/bases.jl

@@ -323,7 +323,12 @@ function _broadcastbasis(::typeof(+), _, _, a, b)
 end
 
 _broadcastbasis(::typeof(+), ::MappedBasisLayouts, ::MappedBasisLayouts, a, b) = broadcastbasis(+, demap(a), demap(b))[basismap(a), :]
-_broadcastbasis(::typeof(+), ::SubBasisLayout, ::SubBasisLayout, a, b) = broadcastbasis(+, parent(a), parent(b))
+function _broadcastbasis(::typeof(+), ::SubBasisLayout, ::SubBasisLayout, a, b)
+    kr_a,jr_a = parentindices(a)
+    kr_b,jr_b = parentindices(b)
+    @assert kr_a == kr_b # frist axes must match
+    view(broadcastbasis(+, parent(a), parent(b)), kr_a, union(jr_a,jr_b))
+end
 _broadcastbasis(::typeof(+), ::SubBasisLayout, _, a, b) = broadcastbasis(+, parent(a), b)
 _broadcastbasis(::typeof(+), _, ::SubBasisLayout, a, b) = broadcastbasis(+, a, parent(b))
 

src/bases/splines.jl

@@ -9,6 +9,8 @@ const HeavisideSpline = Spline{0}
 Spline{o}(pts::AbstractVector{T}) where {o,T} = Spline{o,float(T)}(pts)
 Spline{o}(S::Spline) where {o} = Spline{o}(S.points)
 
+summary(io::IO, L::LinearSpline) = print(io, "LinearSpline($(L.points))")
+
 axes(B::Spline{o}) where o =
     (Inclusion(first(B.points)..last(B.points)), OneTo(length(B.points)+o-1))
 ==(A::Spline{o}, B::Spline{o}) where o = A.points == B.points

test/test_splines.jl

@@ -109,6 +109,13 @@ using ContinuumArrays, LinearAlgebra, Test
             @test (L\b) == [2,2,2]
             B = BroadcastQuasiArray(-, L, L)
             @test L\B == 0Eye(3)
+
+            @testset "sub" begin
+                v = ApplyQuasiArray(*, L[:,2:end], [1,2])
+                f = L * [1,2,3]
+                @test v + f == f + v == L*[1,3,5]
+                @test v + v == L*[0,2,4]
+            end
         end
     end