sum for ApplyLayout(*) and AdjointBasisLayout (#90)

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "ContinuumArrays"
 uuid = "7ae1f121-cc2c-504b-ac30-9b923412ae5c"
-version = "0.7.1"
+version = "0.7.2"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/bases/bases.jl

@@ -404,6 +404,19 @@ function __sum(LAY::ApplyLayout{typeof(*)}, V::AbstractQuasiVector, ::Colon)
     first(apply(*, sum(a[1]; dims=1), tail(a)...))
 end
 
+__sum(::AdjointBasisLayout, Vm::AbstractQuasiMatrix, dims) = permutedims(sum(Vm'; dims=(isone(dims) ? 2 : 1)))
+
+# sum is equivalent to hitting by ones(n) on the left or rifght
+function __sum(LAY::ApplyLayout{typeof(*)}, V::AbstractQuasiMatrix, d::Int)
+    a = arguments(LAY, V)
+    if d == 1
+        *(sum(first(a); dims=1), tail(a)...)
+    else
+        @assert d == 2
+        *(most(a)..., sum(last(a); dims=2))
+    end
+end
+
 function __sum(::MappedBasisLayouts, V::AbstractQuasiArray, dims)
     kr = basismap(V)
     @assert kr isa AbstractAffineQuasiVector

test/runtests.jl

@@ -347,9 +347,14 @@ end
         B = H[5x .+ 1,:]
         @test sum(B; dims=1) * [1,1,1] == [1]
         @test sum(H[:,1:2]; dims=1) * [1,1] == [2]
+        @test sum(H'; dims=2) == permutedims(sum(H; dims=1))
 
         u = H * randn(3)
         @test sum(u[5x .+ 1]) ≈ sum(view(u,5x .+ 1)) ≈ sum(u)/5
+
+        L = LinearSpline([1,2,3,6])
+        D = Derivative(axes(L,1))
+        @test sum(D*L; dims=1) ≈ sum((D*L)'; dims=2)' ≈ [-1 zeros(1,2) 1]
     end
 
     @testset "Poisson" begin
@@ -590,4 +595,4 @@ ContinuumArrays.invmap(::InvQuadraticMap{T}) where T = QuadraticMap{T}()
     end
 end
 
-include("test_basisconcat.jl")
+include("test_basisconcat.jl")