Revamped build script and Travis setup

Author: mfherbst

.travis.yml

@@ -12,6 +12,22 @@ julia:
 matrix:
   allow_failures:
     - julia: nightly
+addons:
+  apt:
+    packages:
+      - libquadmath0
+      - libgomp1
+      - libopenblas-dev
+      - libfftw3-dev
+      - libmpfr-dev
+  homebrew:
+    packages:
+      - gcc@9
+      - fftw
+      - mpfr
+env:
+  - FT_BUILD_FROM_SOURCE=true
+
 notifications:
   email: false
 after_success:

deps/build.jl

@@ -1,89 +1,78 @@
 using BinaryProvider
+import Libdl
+
+version = "0.2.7"
 
 if arch(platform_key_abi()) != :x86_64
     @warn "FastTransforms has only been tested on x86_64 architectures."
 end
+if !Sys.islinux() && !Sys.isapple()
+    error("Sorry ... unsupported OS. Feel free to file a PR to add support.")
+end
 
-ft_build_from_source = get(ENV, "FT_BUILD_FROM_SOURCE", "false")
+const extension = Sys.isapple() ? "dylib" : "so"
+print_error() = error(
+    "FastTransforms could not be properly installed.\nCheck you have all dependencies installed." *
+   " To install the dependencies you can use:\n" *
+   "On Ubuntu / Debian \n" *
+   "   sudo apt install gcc libblas-dev libopenblas-base libfftw3-dev libmpfr-dev\n" *
+   "On MacOS \n" *
+   "   brew install gcc libblas-dev libopenblas-base libfftw3-dev libmpfr-dev\n"
+)
 
+# Rationale is as follows: The build is pretty fast, so on Linux it is typically easiest
+# to just use the gcc of the system to build the library and include it. On MacOS, however,
+# we need to actually install a gcc first, because Apple's OS comes only shipped with clang,
+# so here we download the binary.
+ft_build_from_source = get(ENV, "FT_BUILD_FROM_SOURCE", Sys.isapple() ? "false" : "true")
 if ft_build_from_source == "true"
     println("Building from source.")
-    if Sys.isapple()
-        script = raw"""
-        brew update
-        brew install gcc@8 fftw mpfr
-        rm -rf FastTransforms
-        git clone -b v0.2.7 https://github.com/MikaelSlevinsky/FastTransforms.git FastTransforms
-        cd FastTransforms
-        make lib CC=gcc-8 FT_USE_APPLEBLAS=1
-        cd ..
-        ln -sf FastTransforms/libfasttransforms.dylib libfasttransforms.dylib
-        """
-        run(`/bin/bash -c $(script)`)
-    elseif Sys.islinux()
-        script = raw"""
-        sudo apt-get update
-        sudo add-apt-repository ppa:ubuntu-toolchain-r/test
-        sudo apt-get install gcc-8 libblas-dev libopenblas-base libfftw3-dev libmpfr-dev
-        rm -rf FastTransforms
-        git clone -b v0.2.7 https://github.com/MikaelSlevinsky/FastTransforms.git FastTransforms
+
+    extra = Sys.isapple() ? "FT_USE_APPLEBLAS=1" : ""
+    script = """
+        set -e
+        set -x
+
+        if [ -d "FastTransforms" ]; then
+            cd FastTransforms
+            git fetch
+            git reset --hard
+            git checkout -b v$version
+            cd ..
+        else
+            git clone -b v$version https://github.com/MikaelSlevinsky/FastTransforms.git FastTransforms
+        fi
+        ln -sf FastTransforms/libfasttransforms.$extension libfasttransforms.$extension
+
+        echo
+        echo
+
         cd FastTransforms
-        make lib CC=gcc-8
-        cd ..
-        ln -sf FastTransforms/libfasttransforms.so libfasttransforms.so
-        """
+        make clean
+        make lib $extra
+    """
+
+    try
         run(`/bin/bash -c $(script)`)
-    else
-        @warn "FastTransforms could not be built from source with the current build.jl script. Have you considered filing an issue? https://github.com/JuliaApproximation/FastTransforms.jl/issues"
+    catch IOError
+        print_error()
     end
 else
     println("Installing by downloading binaries.")
-    if Sys.isapple()
-        run(`brew update`)
-        run(`brew install gcc@8 fftw mpfr`)
-        const libfasttransforms = joinpath(dirname(@__DIR__), "deps", "libfasttransforms.dylib")
-        GCC = BinaryProvider.detect_compiler_abi().gcc_version
-        println("Building with ", GCC, ".")
-        const release = "https://github.com/MikaelSlevinsky/FastTransforms/releases/download/v0.2.7/libfasttransforms.v0.2.7"
-        if GCC == :gcc4
-            download(release*".gcc-4.9.dylib", libfasttransforms)
-        elseif GCC == :gcc5
-            download(release*".gcc-5.dylib", libfasttransforms)
-        elseif GCC == :gcc6
-            download(release*".gcc-6.dylib", libfasttransforms)
-        elseif GCC == :gcc7
-            download(release*".gcc-7.dylib", libfasttransforms)
-        elseif GCC == :gcc8
-            download(release*".gcc-8.dylib", libfasttransforms)
-        elseif GCC == :gcc9
-            download(release*".gcc-9.dylib", libfasttransforms)
-        else
-            @warn "Please ensure you have a version of gcc from gcc-4.9 to gcc-9."
-        end
-    elseif Sys.islinux()
-        run(`sudo add-apt-repository ppa:ubuntu-toolchain-r/test`)
-        run(`sudo apt-get update`)
-        run(`sudo apt-get install gcc-8 libblas-dev libopenblas-base libfftw3-dev libmpfr-dev`)
-        const libfasttransforms = joinpath(dirname(@__DIR__), "deps", "libfasttransforms.so")
-        GCC = BinaryProvider.detect_compiler_abi().gcc_version
-        println("Building with ", GCC, ".")
-        const release = "https://github.com/MikaelSlevinsky/FastTransforms/releases/download/v0.2.7/libfasttransforms.v0.2.7"
-        if GCC == :gcc4
-            download(release*".gcc-4.9.so", libfasttransforms)
-        elseif GCC == :gcc5
-            download(release*".gcc-5.so", libfasttransforms)
-        elseif GCC == :gcc6
-            download(release*".gcc-6.so", libfasttransforms)
-        elseif GCC == :gcc7
-            download(release*".gcc-7.so", libfasttransforms)
-        elseif GCC == :gcc8
-            download(release*".gcc-8.so", libfasttransforms)
-        elseif GCC == :gcc9
-            download(release*".gcc-9.so", libfasttransforms)
-        else
-            @warn "Please ensure you have a version of gcc from gcc-4.9 to gcc-9."
-        end
-    else
-        @warn "FastTransforms could not be installed by downloading binaries. Have you tried building from source?"
+
+    const GCC = BinaryProvider.detect_compiler_abi().gcc_version
+    namemap = Dict(:gcc4 => "gcc-4.9", :gcc5 => "gcc-5", :gcc6 => "gcc-6",
+                   :gcc7 => "gcc-7", :gcc8 => "gcc-8", :gcc9 => "gcc-9")
+    if !(GCC in keys(namemap))
+        error("Please ensure you have a version of gcc from gcc-4.9 to gcc-9.")
     end
+    download("https://github.com/MikaelSlevinsky/FastTransforms/releases/download/" *
+             "v$version/libfasttransforms.v$version.$(namemap[GCC]).$extension",
+             joinpath(dirname(@__DIR__), "deps", "libfasttransforms.$extension"))
+end
+
+const lft_directiory = joinpath(dirname(@__DIR__), "deps")
+const libfasttransforms = Libdl.find_library("libfasttransforms", [lft_directiory])
+if libfasttransforms === nothing || length(libfasttransforms) == 0
+    print_error()
 end

src/libfasttransforms.jl

@@ -1,6 +1,7 @@
-const libfasttransforms = joinpath(dirname(@__DIR__), "deps", "libfasttransforms")
+const lft_directiory = joinpath(dirname(@__DIR__), "deps")
+const libfasttransforms = find_library("libfasttransforms", [lft_directiory])
 
-if !(find_library(libfasttransforms) ≡ libfasttransforms)
+if libfasttransforms === nothing || length(libfasttransforms) == 0
     error("FastTransforms is not properly installed. Please run Pkg.build(\"FastTransforms\") ",
           "and restart Julia.")
 end