Use pkgdir
#165
Merged
Use pkgdir
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 12 12
Lines 2002 2002
=======================================
Hits 1639 1639
Misses 363 363 Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Julia 1.4, there is the very convenient
pkgdirwhich many people overlook. Via code searches, I noticed that this repository uses somedirname(dirname(pathof(FastTransforms)))which is the same aspkgdir(FastTransforms), so this PR proposes to replace that.