Skip to content

allow views in *, \ and contiguous lmul! and ldiv! #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

MikaelSlevinsky
Copy link
Member

Alternate way to close #178 instead of #179.

Technically, all that #178 needs is to finish 3ba4ee3

but this PR goes further and allows unit strided array calls with lmul! and ldiv! (in-place transforms). Later, the C library can be expanded to include more general strides.

@MikaelSlevinsky
Copy link
Member Author

CC @jishnub

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #182 (bfc4e71) into master (8a82d79) will decrease coverage by 0.10%.
The diff coverage is 72.46%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   78.79%   78.69%   -0.11%     
==========================================
  Files          13       13              
  Lines        2108     2145      +37     
==========================================
+ Hits         1661     1688      +27     
- Misses        447      457      +10     
Impacted Files Coverage Δ
src/libfasttransforms.jl 77.65% <72.46%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MikaelSlevinsky MikaelSlevinsky merged commit cb622ba into master Aug 3, 2022
@MikaelSlevinsky MikaelSlevinsky deleted the lmul!-on-strided branch August 3, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should multiplication of FTPlan take StridedArrays as arguments instead of Arrays?
1 participant