Skip to content

Limit FFTW compat to v1.6 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 12, 2023

FFTW v1.7 introduces certain changes to the type of r2rFFTWPlan (these are improvements over those introduced in v1.6, my bad for not incorporating it all in that version). Unfortunately, this change has led to breakages here. This PR limits the upper bound of FFTW to v1.6, and I'll submit another PR with the changes for v1.7 compatibility.

It also removes the redundant test on v1.9, as v1 points to v1.9 now.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8d92144) 81.76% compared to head (cbda4f0) 81.76%.

❗ Current head cbda4f0 differs from pull request most recent head 65524b9. Consider uploading reports for the commit 65524b9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          15       15           
  Lines        2539     2539           
=======================================
  Hits         2076     2076           
  Misses        463      463           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub mentioned this pull request Jun 12, 2023
@dlfivefifty dlfivefifty merged commit 0e5214f into JuliaApproximation:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants