separate out windows CI tasks #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 81.76% 83.21% +1.44%
==========================================
Files 15 15
Lines 2539 2716 +177
==========================================
+ Hits 2076 2260 +184
+ Misses 463 456 -7 ☔ View full report in Codecov by Sentry. |
|
This is good, but feel free to take it a step further and have a separate ci.yml for Windows, with separate badge too, until things are back ported and settle down. |
|
Updated, and I've removed the Windows test on Julia v1.7, as that won't get fixed |
|
Gentle bump |
|
Gentle bump. The tests all pass now, with the windows tests disabled on Julia versions <v1.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating out the windows CI runs from the mac/linux ones will continue the latter even if the windows ones fail, and unlike continue-on-error, this won't report a success result status if tasks fail.
Once JuliaLang/julia#50135 is backported, perhaps we should run the tests for WIndows only on Julia v1.9.2+