Make sure FFTW is maximally used #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
- Coverage 52.68% 52.3% -0.38%
=========================================
Files 33 33
Lines 3166 3185 +19
=========================================
- Hits 1668 1666 -2
- Misses 1498 1519 +21
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
- Coverage 52.68% 52.3% -0.38%
=========================================
Files 33 33
Lines 3166 3185 +19
=========================================
- Hits 1668 1666 -2
- Misses 1498 1519 +21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous generic FFT implementation would use generic FFT in various places even when FFTW was applicable. This is, of course, highly undesirable!
The changes here fix that, and also add tests to make sure that FFTW plans continue to be used for standard floating points. There is a runtime warning if generic fft's are used for Float32 or Float64 numbers.
The expected interface of AbstractFFTs is not entirely obvious. Some plans are only implemented for real numbers, some only for complex numbers, some plans are implemented in terms of other plans. As a result, when implementing plans for AbstractFloat we have to be careful in the typing of our implementation.