Skip to content

stop conv from mutating input #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

stop conv from mutating input #89

wants to merge 1 commit into from

Conversation

vincentcp
Copy link

Closes #67

Copy link
Member

@dlfivefifty dlfivefifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a two stage version: conv! which mutates and conv which calls conv!.

Also, add tests please

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   80.83%   80.76%   -0.07%     
==========================================
  Files          12       12              
  Lines        1247     1248       +1     
==========================================
  Hits         1008     1008              
- Misses        239      240       +1
Impacted Files Coverage Δ
src/fftBigFloat.jl 82.03% <100%> (+0.14%) ⬆️
src/specialfunctions.jl 53.4% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abf49e...159ff60. Read the comment docs.

MikaelSlevinsky added a commit that referenced this pull request Feb 8, 2021
close the longest open pull request? #89, fixing #67

also, stop the type piracy of DSP's conv for certain bitstype floating-point types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convolution overwrites input.
3 participants