Skip to content

Commit 3a563d5

Browse files
committed
Revert "add Jacobi matrices for RectPolynomial"
This reverts commit b2f95fe.
1 parent b2f95fe commit 3a563d5

File tree

2 files changed

+2
-32
lines changed

2 files changed

+2
-32
lines changed

src/rect.jl

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ function getindex(P::RectPolynomial, xy::StaticVector{2}, JR::BlockOneTo)
3636
N = size(JR,1)
3737
DiagTrav(A[x,OneTo(N)] .* B[y,OneTo(N)]')
3838
end
39-
# Actually Jxᵀ
40-
function jacobimatrix(::Val{1}, P::RectPolynomial)
41-
A,B = P.args
42-
X = jacobimatrix(A)
43-
P * KronTrav(Eye{eltype(X)}(∞), X)
44-
end
45-
# Actually Jyᵀ
46-
function jacobimatrix(::Val{2}, P::RectPolynomial)
47-
A,B = P.args
48-
Y = jacobimatrix(B)
49-
P * KronTrav(Y, Eye{eltype(Y)}(∞))
50-
end
5139
@simplify function *(Dx::PartialDerivative{1}, P::RectPolynomial)
5240
A,B = P.args
5341
U,M = (Derivative(axes(A,1))*A).args
@@ -162,4 +150,4 @@ function transform_ldiv(K::KronPolynomial{d,V,<:Fill{<:Legendre}}, f::Union{Abst
162150
T = KronPolynomial{d}(Fill(ChebyshevT{V}(), size(K.args)...))
163151
dat = (T \ f).array
164152
DiagTrav(pad(FastTransforms.th_cheb2leg(paddeddata(dat)), axes(dat)...))
165-
end
153+
end

test/test_rect.jl

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,24 +43,6 @@ using ContinuumArrays: plotgridvalues
4343
@test f[SVector(0.1,0.2)] exp(0.1*cos(0.1))
4444
end
4545

46-
@testset "Jacobi matrices" begin
47-
T = ChebyshevT()
48-
U = ChebyshevU()
49-
TU = RectPolynomial(T, U)
50-
X = jacobimatrix(Val{1}(), TU)
51-
Y = jacobimatrix(Val{2}(), TU)
52-
𝐱 = axes(TU, 1)
53-
x, y = first.(𝐱), last.(𝐱)
54-
@test_broken TU \ (x .* TU) # Should create X, but it fails
55-
@test_broken TU \ (y .* TU) # Should create Y, but it fails
56-
f = expand(TU, splat((x,y) -> exp(x*cos(y-0.1))))
57-
g = expand(TU, splat((x,y) -> x*exp(x*cos(y-0.1))))
58-
h = expand(TU, splat((x,y) -> y*exp(x*cos(y-0.1))))
59-
N = 10
60-
@test (TU \ (X * (TU \ f)))[Block.(1:N)] (TU \ g)[Block.(1:N)]
61-
@test (TU \ (Y * (TU \ f)))[Block.(1:N)] (TU \ h)[Block.(1:N)]
62-
end
63-
6446
@testset "Conversion" begin
6547
T = ChebyshevT()
6648
U = ChebyshevU()
@@ -137,4 +119,4 @@ using ContinuumArrays: plotgridvalues
137119
@test x == SVector.(ChebyshevGrid{2}(40), ChebyshevGrid{2}(40)')
138120
@test F == ones(40,40)
139121
end
140-
end
122+
end

0 commit comments

Comments
 (0)