Skip to content

use fixed ag-grid version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2019
Merged

use fixed ag-grid version #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77b30fb
use fixed ag-grid version
pfitzseb Feb 27, 2019
3410a2a
fix tests
pfitzseb Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ag-grid.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.1.0
2 changes: 1 addition & 1 deletion deps/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ag-grid
ag-grid*
build.log
20 changes: 11 additions & 9 deletions deps/build.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
isdir(joinpath(@__DIR__, "ag-grid")) || mkdir(joinpath(@__DIR__, "ag-grid"))
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))

ag_grid_base = joinpath(@__DIR__, "ag-grid", "ag-grid.js")
isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community/dist/ag-grid-community.min.noStyle.js", ag_grid_base)
isdir(joinpath(@__DIR__, "ag-grid-$(version)")) || mkdir(joinpath(@__DIR__, "ag-grid-$(version)"))

ag_grid_base_style = joinpath(@__DIR__, "ag-grid", "ag-grid.css")
isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-grid.css", ag_grid_base_style)
ag_grid_base = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.js")
isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community@$(version)/dist/ag-grid-community.min.noStyle.js", ag_grid_base)

ag_grid_light = joinpath(@__DIR__, "ag-grid", "ag-grid-light.css")
isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham.css", ag_grid_light)
ag_grid_base_style = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.css")
isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-grid.css", ag_grid_base_style)

ag_grid_dark = joinpath(@__DIR__, "ag-grid", "ag-grid-dark.css")
isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)
ag_grid_light = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-light.css")
isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham.css", ag_grid_light)

ag_grid_dark = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-dark.css")
isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)
3 changes: 2 additions & 1 deletion src/TableView.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ export showtable
const ag_grid_imports = []

function __init__()
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
empty!(ag_grid_imports)
for f in ["ag-grid.js", "ag-grid.css", "ag-grid-light.css", "ag-grid-dark.css"]
push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid", f)))
push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", f)))
end
end

Expand Down
4 changes: 3 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using TableView
using Test, WebIO

@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid", "ag-grid.js"))
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))

@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", "ag-grid.js"))

nttable = [
(a = 2.0, b = 3),
Expand Down