Skip to content

More extensive use of Polyester #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Feb 15, 2024

  • Add Polyester approximate sparsity detection
  • Polyester colored AD

Tests were already present -- they just took the ForwardDiff fallback.

@avik-pal avik-pal marked this pull request as draft February 15, 2024 18:57
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (01a5e5f) 85.25% compared to head (9fa3444) 84.34%.

Files Patch % Lines
ext/SparseDiffToolsPolyesterForwardDiffExt.jl 51.85% 13 Missing ⚠️
ext/SparseDiffToolsPolyesterExt.jl 75.00% 11 Missing ⚠️
src/highlevel/coloring.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   85.25%   84.34%   -0.91%     
==========================================
  Files          23       24       +1     
  Lines        1404     1476      +72     
==========================================
+ Hits         1197     1245      +48     
- Misses        207      231      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal marked this pull request as ready for review February 15, 2024 20:24
@avik-pal
Copy link
Contributor Author

Holding off on the polyester version for in place version. Maybe someone more versed in polyester can get it working

@avik-pal avik-pal changed the title More extensive use of Polyester [WIP] More extensive use of Polyester Feb 15, 2024
@avik-pal avik-pal changed the title [WIP] More extensive use of Polyester More extensive use of Polyester Feb 15, 2024
@avik-pal
Copy link
Contributor Author

cc @ChrisRackauckas

@avik-pal
Copy link
Contributor Author

@ChrisRackauckas you will have to merge and register

@ChrisRackauckas ChrisRackauckas merged commit d2f35b7 into JuliaDiff:master Feb 16, 2024
@avik-pal avik-pal deleted the ap/speed branch February 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants