Skip to content

Commit 1aacddf

Browse files
committed
Started adding tests for missing coverage
1 parent 0121fac commit 1aacddf

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

src/generic.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
@inline metric::Kernel) = κ.metric
22

33
## Allows to iterate over kernels
4-
Base.length(::Kernel) = 1 #TODO Add test
5-
6-
Base.iterate(k::Kernel) = (k,nothing) #TODO Add test
7-
Base.iterate(k::Kernel, ::Any) = nothing #TODO Add test
4+
Base.length(::Kernel) = 1
5+
Base.iterate(k::Kernel) = (k,nothing)
6+
Base.iterate(k::Kernel, ::Any) = nothing
87

98
### Syntactic sugar for creating matrices and using kernel functions
109
for k in [:ExponentialKernel,:SqExponentialKernel,:GammaExponentialKernel,:MaternKernel,:Matern32Kernel,:Matern52Kernel,:LinearKernel,:PolynomialKernel,:ExponentiatedKernel,:ZeroKernel,:WhiteKernel,:ConstantKernel,:RationalQuadraticKernel,:GammaRationalQuadraticKernel]

src/transform/scaletransform.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ _transform(t::ScaleTransform{<:AbstractVector{<:Real}},X::AbstractMatrix{<:Real}
5252
transform(t::ScaleTransform{<:Base.RefValue{<:Real}},x::AbstractVecOrMat,obsdim::Int=defaultobs) = t.s[] .* x
5353

5454
Base.isequal(t::ScaleTransform{T},t2::ScaleTransform{T}) where {T<:Base.RefValue{<:Real}} = isequal(t.s[],t2.s[])
55-
Base.:==(t::ScaleTransform{T},t2::ScaleTransform{T}) where {T<:AbstractVector{<:Real}} = isequal(t.s,t2.s)
55+
Base.isequal(t::ScaleTransform{T},t2::ScaleTransform{T}) where {T<:AbstractVector{<:Real}} = isequal(t.s,t2.s)

test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@ include("test_constructors.jl")
1010
include("test_transform.jl")
1111
include("test_distances.jl")
1212
include("test_kernels.jl")
13+
include("test_generic.jl")
1314
#include("types.jl")
1415
end

test/test_generic.jl

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
using KernelFunctions
2+
3+
k = SqExponentialKernel()
4+
5+
@testset "Generic functions to test" begin
6+
@test length(k) == 1
7+
@test iterate(k) == (k,nothing)
8+
@test iterate(k,1) == nothing
9+
end

0 commit comments

Comments
 (0)