Deprecate TensorProduct correctly (#243)

devmotion · web-flow · commit 3fca6fc0e240 · 2021-01-20T19:33:09.000+01:00
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "KernelFunctions"
 uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
-version = "0.8.19"
+version = "0.8.20"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
diff --git a/src/deprecated.jl b/src/deprecated.jl
@@ -8,7 +8,4 @@
     PiecewisePolynomialKernel{V}(size(A, 1)), LinearTransform(cholesky(A).U)
 )
 
-@deprecate TensorProduct(kernels) KernelTensorProduct(kernels)
-@deprecate TensorProduct(kernel::Kernel, kernels::Kernel...) KernelTensorProduct(
-    kernel, kernels...
-)
+Base.@deprecate_binding TensorProduct KernelTensorProduct
diff --git a/test/kernels/kerneltensorproduct.jl b/test/kernels/kerneltensorproduct.jl
@@ -28,9 +28,10 @@
     end
 
     # Deprecations
-    @test (@test_deprecated TensorProduct(k1, k2)) == k1 ⊗ k2
-    @test (@test_deprecated TensorProduct((k1, k2))) == k1 ⊗ k2
-    @test (@test_deprecated TensorProduct([k1, k2])) == k1 ⊗ k2
+    @test TensorProduct === KernelTensorProduct
+    @test TensorProduct(k1, k2) == k1 ⊗ k2
+    @test TensorProduct((k1, k2)) == k1 ⊗ k2
+    @test TensorProduct([k1, k2]) == k1 ⊗ k2
 
     # Standardised tests.
     TestUtils.test_interface(kernel1, ColVecs{Float64})

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,4 @@`
`8`	`8`	`PiecewisePolynomialKernel{V}(size(A, 1)), LinearTransform(cholesky(A).U)`
`9`	`9`	`)`
`10`	`10`
`11`		`-@deprecate TensorProduct(kernels) KernelTensorProduct(kernels)`
`12`		`-@deprecate TensorProduct(kernel::Kernel, kernels::Kernel...) KernelTensorProduct(`
`13`		`- kernel, kernels...`
`14`		`-)`
	`11`	`+Base.@deprecate_binding TensorProduct KernelTensorProduct`