Eltype in ones

Author: Will Tebbutt

src/basekernels/fbm.jl

@@ -50,7 +50,7 @@ _mod(x::RowVecs) = vec(sum(abs2, x.X; dims=2))
 
 function kernelmatrix(κ::FBMKernel, x::AbstractVector)
     modx = _mod(x)
-    modx_wide = modx * ones(1, length(modx)) # ad perf hack -- is unit tested
+    modx_wide = modx * ones(eltype(modx), 1, length(modx)) # ad perf hack -- is unit tested
     modxx = pairwise(SqEuclidean(), x)
     return _fbm.(modx_wide, modx_wide', modxx, only(κ.h))
 end
@@ -64,8 +64,8 @@ end
 
 function kernelmatrix(κ::FBMKernel, x::AbstractVector, y::AbstractVector)
     modxy = pairwise(SqEuclidean(), x, y)
-    modx_wide = _mod(x) * ones(1, length(y)) # ad perf hack -- is unit tested
-    mody_wide = _mod(y) * ones(1, length(x)) # ad perf hack -- is unit tested
+    modx_wide = _mod(x) * ones(eltype(modxy), 1, length(y)) # ad perf hack -- is unit tested
+    mody_wide = _mod(y) * ones(eltype(modxy), 1, length(x)) # ad perf hack -- is unit tested
     return _fbm.(modx_wide, mody_wide', modxy, only(κ.h))
 end
 

src/kernels/normalizedkernel.jl

@@ -21,15 +21,15 @@ end
 
 function kernelmatrix(κ::NormalizedKernel, x::AbstractVector, y::AbstractVector)
     x_diag = kernelmatrix_diag(κ.kernel, x)
-    x_diag_wide = x_diag * ones(1, length(y)) # ad perf hack. Is unit tested.
+    x_diag_wide = x_diag * ones(eltype(x_diag), 1, length(y)) # ad perf hack. Is unit tested
     y_diag = kernelmatrix_diag(κ.kernel, y)
-    y_diag_wide = y_diag * ones(1, length(x)) # ad perf hack. Is unit tested.
+    y_diag_wide = y_diag * ones(eltype(y_diag), 1, length(x)) # ad perf hack. Is unit tested
     return kernelmatrix(κ.kernel, x, y) ./ sqrt.(x_diag_wide .* y_diag_wide')
 end
 
 function kernelmatrix(κ::NormalizedKernel, x::AbstractVector)
     x_diag = kernelmatrix_diag(κ.kernel, x)
-    x_diag_wide = x_diag * ones(1, length(x_diag)) # ad perf hack. Is unit tested.
+    x_diag_wide = x_diag * ones(eltype(x_diag), 1, length(x)) # ad perf hack. Is unit tested
     return kernelmatrix(κ.kernel, x) ./ sqrt.(x_diag_wide .* x_diag_wide')
 end