Skip to content

Commit ab866b9

Browse files
moletdevmotionwilltebbutt
authored
Preserve Float type for Periodic Kernel (#560)
* 0.5d -> d/2 change for kappa function of periodic kernel * test added * strip trailing whitespace * Update test/basekernels/periodic.jl Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]> Co-authored-by: Will Tebbutt <[email protected]>
1 parent 7389f31 commit ab866b9

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "KernelFunctions"
22
uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
3-
version = "0.10.63"
3+
version = "0.10.64"
44

55
[deps]
66
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/basekernels/periodic.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ PeriodicKernel(T::DataType, dims::Int=1) = PeriodicKernel(; r=ones(T, dims))
3434

3535
metric::PeriodicKernel) = Sinus.r)
3636

37-
kappa(::PeriodicKernel, d::Real) = exp(-0.5d)
37+
kappa(::PeriodicKernel, d::Real) = exp(-d / 2)
3838

3939
function Base.show(io::IO, κ::PeriodicKernel)
4040
return print(io, "Periodic Kernel, length(r) = $(length.r))")

test/basekernels/periodic.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
@test k(v1, v2) exp(-0.5 * sum(abs2, sinpi.(v1 - v2) ./ r))
99
@test k(v1, v2) == k(v2, v1)
1010
@test PeriodicKernel(3)(v1, v2) == PeriodicKernel(; r=ones(3))(v1, v2)
11+
@test PeriodicKernel(; r=Float32.(r))(Float32.(v1), Float32.(v2)) isa Float32
1112
@test repr(k) == "Periodic Kernel, length(r) = $(length(r))"
1213

1314
# Standardised tests.

0 commit comments

Comments
 (0)