Skip to content

Commit d6a95fc

Browse files
committed
Small correction due to the change of RefValue
1 parent 5abdada commit d6a95fc

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/generic.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ end
2424
## Constructors for kernels without parameters
2525
for kernel in [:ExponentialKernel,:SqExponentialKernel,:Matern32Kernel,:Matern52Kernel,:ExponentiatedKernel]
2626
@eval begin
27-
$kernel::T=1.0) where {T<:Real} = $kernel{T,ScaleTransform{T}}(ScaleTransform(ρ))
27+
$kernel::T=1.0) where {T<:Real} = $kernel{T,ScaleTransform{Base.RefValue{T}}}(ScaleTransform(ρ))
2828
$kernel::A) where {A<:AbstractVector{<:Real}} = $kernel{eltype(A),ScaleTransform{A}}(ScaleTransform(ρ))
2929
$kernel(t::Tr) where {Tr<:Transform} = $kernel{eltype(t),Tr}(t)
3030
end
3131
end
3232

33-
function set!()
34-
33+
function set!(k::Kernel,x)
34+
@error "Setting parameters to this kernel is either not possible or has not been implemented"
3535
end
3636

3737
function set!(k::Kernel{T,ScaleTransform{Base.RefValue{<:Tρ}}}::Tρ) where {T,Tρ<:Real}

src/transform/scaletransform.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ end
1515

1616
function ScaleTransform(s::T=1.0) where {T<:Real}
1717
@check_args(ScaleTransform, s, s > zero(T), "s > 0")
18-
ScaleTransform{T}(Ref(s))
18+
ScaleTransform{Base.RefValue{T}}(Ref(s))
1919
end
2020

2121
function ScaleTransform(s::T,dims::Integer) where {T<:Real} # TODO Add test
@@ -49,4 +49,4 @@ end
4949
transform(t::ScaleTransform{<:AbstractVector{<:Real}},x::AbstractVector{<:Real},obsdim::Int=defaultobs) = t.s .* x
5050
_transform(t::ScaleTransform{<:AbstractVector{<:Real}},X::AbstractMatrix{<:Real},obsdim::Int=defaultobs) = obsdim == 1 ? t.s'.*X : t.s .* X
5151

52-
transform(t::ScaleTransform{Base.RefValue{<:Real}},x::AbstractVecOrMat,obsdim::Int=defaultobs) = t.s[] .* x
52+
transform(t::ScaleTransform{<:Base.RefValue{<:Real}},x::AbstractVecOrMat,obsdim::Int=defaultobs) = t.s[] .* x

0 commit comments

Comments
 (0)