tests pass

Author: dlfivefifty

src/AbstractBlockBandedMatrix.jl

@@ -25,15 +25,19 @@ struct BlockBandedColumns{LAY} <: AbstractBlockBandedLayout end
 struct BlockBandedRows{LAY} <: AbstractBlockBandedLayout end
 
 const BandedBlockBandedColumnMajor = BandedBlockBandedColumns{ColumnMajor}
-const BandedBlockBandedRowMajor = BandedBlockBandedColumns{RowMajor}
+const BandedBlockBandedRowMajor = BandedBlockBandedRows{ColumnMajor}
 const BlockBandedColumnMajor = BlockBandedColumns{ColumnMajor}
-const BlockBandedRowMajor = BlockBandedColumns{RowMajor}
+const BlockBandedRowMajor = BlockBandedRows{ColumnMajor}
 
-transposelayout(::BandedBlockBandedColumnMajor) = BandedBlockBandedRowMajor()
-transposelayout(::BandedBlockBandedRowMajor) = BandedBlockBandedColumnMajor()
-transposelayout(::BlockBandedColumnMajor) = BlockBandedRowMajor()
-transposelayout(::BlockBandedRowMajor) = BlockBandedColumnMajor()
+transposelayout(::BandedBlockBandedColumns{Lay}) where Lay = BandedBlockBandedRows{Lay}()
+transposelayout(::BandedBlockBandedRows{Lay}) where Lay = BandedBlockBandedColumns{Lay}()
+transposelayout(::BlockBandedColumns{Lay}) where Lay = BlockBandedRows{Lay}()
+transposelayout(::BlockBandedRows{Lay}) where Lay = BlockBandedColumns{Lay}()
 
+conjlayout(::Type{T}, ::BandedBlockBandedColumns{Lay}) where {T<:Complex,Lay} = BandedBlockBandedColumns{typeof(conjlayout(T,Lay))}()
+conjlayout(::Type{T}, ::BandedBlockBandedRows{Lay}) where {T<:Complex,Lay} = BandedBlockBandedRows{typeof(conjlayout(T,Lay))}()
+conjlayout(::Type{T}, ::BlockBandedColumns{Lay}) where {T<:Complex,Lay} = BlockBandedColumns{typeof(conjlayout(T,Lay))}()
+conjlayout(::Type{T}, ::BlockBandedRows{Lay}) where {T<:Complex,Lay} = BlockBandedRows{typeof(conjlayout(T,Lay))}()
 
 
 # AbstractBandedMatrix must implement

src/BlockBandedMatrices.jl

@@ -27,7 +27,7 @@ import ArrayLayouts: BlasMatLmulVec, MatLmulVec, MatLmulMat,
                     AbstractColumnMajor, DenseColumnMajor, ColumnMajor,
                     DiagonalLayout, MulAdd, mul, colsupport, rowsupport,
                     _qr, _factorize, _copyto!, zero!, layout_replace_in_print_matrix,
-                    transposelayout
+                    transposelayout, conjlayout
 
 import BlockArrays: blocksize, blockcheckbounds, BlockedUnitRange, blockisequal, DefaultBlockAxis,
                         Block, BlockSlice, unblock, block, blockindex,

test/test_adjtransblockbanded.jl

@@ -1,8 +1,12 @@
-using BlockBandedMatrices
+using BlockBandedMatrices, ArrayLayouts, Test
+import BlockBandedMatrices: BandedBlockBandedRowMajor, BandedBlockBandedRows
 
 @testset "Adj/Trans" begin
     A = BandedBlockBandedMatrix(randn(ComplexF64,10,14), 1:4,2:5, (1,2), (2,1))
 
+    @test MemoryLayout(transpose(A)) isa BandedBlockBandedRowMajor
+    @test MemoryLayout(A') isa BandedBlockBandedRows
+
     @test A'[Block(1,1)] == A[Block(1,1)]'
     @test A'[Block(2,3)] == A[Block(3,2)]'
     @test transpose(A)[Block(1,1)] == transpose(A[Block(1,1)])