Skip to content

convert extended but not imported from Base #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baggepinnen opened this issue Feb 22, 2023 · 1 comment · Fixed by #101
Closed

convert extended but not imported from Base #100

baggepinnen opened this issue Feb 22, 2023 · 1 comment · Fixed by #101
Assignees

Comments

@baggepinnen
Copy link

This package defines convert without importing Base.convert, is that intended?

convert(::Type{Matrix}, H::Householder{T}) where {T} = lmul!(H, Matrix{T}(I, size(H, 1), size(H, 1)))

When trying to use it, I also get an error

julia> GenericLinearAlgebra.convert(Matrix, h2.τ[1])
ERROR: DimensionMismatch: 
Stacktrace:
 [1] lmul!(H::GenericLinearAlgebra.Householder{BigFloat, SubArray{BigFloat, 1, Matrix{BigFloat}, Tuple{UnitRange{Int64}, Int64}, true}}, A::Matrix{BigFloat})
   @ GenericLinearAlgebra ~/.julia/packages/GenericLinearAlgebra/w5JSi/src/householder.jl:24
 [2] convert(#unused#::Type{Matrix}, H::GenericLinearAlgebra.Householder{BigFloat, SubArray{BigFloat, 1, Matrix{BigFloat}, Tuple{UnitRange{Int64}, Int64}, true}})
   @ GenericLinearAlgebra ~/.julia/packages/GenericLinearAlgebra/w5JSi/src/householder.jl:145
 [3] top-level scope
   @ REPL[27]:1
@andreasnoack
Copy link
Member

No that is definitely not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants