Skip to content

Add GenericSVD.jl here? #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisRackauckas opened this issue Oct 29, 2016 · 6 comments
Closed

Add GenericSVD.jl here? #20

ChrisRackauckas opened this issue Oct 29, 2016 · 6 comments

Comments

@ChrisRackauckas
Copy link
Member

It seems like it fits nicely here, and there is no need to have it as a separate package. @simonbyrne

@ChrisRackauckas
Copy link
Member Author

There is mention of and SVD solver here, what's the difference?

@simonbyrne
Copy link
Contributor

This package isn't registered: I get the impression that it is a bit experimental

GenericSVD.jl was based on this code, but has a bit more polish, and deals with a few more edge cases.

@simonbyrne
Copy link
Contributor

Now it has been registered, this would probably be a good idea.

@andreasnoack
Copy link
Member

This package is now registered and I think the svd here covers the same functionality as GenericSVD so I'll close.

@olof3
Copy link

olof3 commented Dec 22, 2020

It seems like some things that were fixed in the GenericSVD package are still broken in this package, for example that the full kwarg is respected

using GenericLinearAlgebra
svd(big.(randn(5,2)), full=true)

I guess there could be others as well.

Some simple tests that perhaps could be reused are found here
https://github.com/JuliaLinearAlgebra/GenericSVD.jl/pull/20/files

@simonbyrne
Copy link
Contributor

Added support for full in #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants