Improvements to blockedunitrange

Author: dlfivefifty

Project.toml

@@ -21,7 +21,7 @@ BandedMatrices = "0.16"
 BlockArrays = "0.14.5, 0.15"
 BlockBandedMatrices = "0.10"
 FillArrays = "0.11"
-InfiniteArrays = "0.10"
+InfiniteArrays = "0.10.6"
 LazyArrays = "0.20.2, 0.21"
 LazyBandedMatrices = "0.5"
 MatrixFactorizations = "0.8"

src/InfiniteLinearAlgebra.jl

@@ -2,7 +2,7 @@ module InfiniteLinearAlgebra
 using BlockArrays, BlockBandedMatrices, BandedMatrices, LazyArrays, LazyBandedMatrices, SemiseparableMatrices,
         FillArrays, InfiniteArrays, MatrixFactorizations, ArrayLayouts, LinearAlgebra
 
-import Base: +, -, *, /, \, ^, OneTo, getindex, promote_op, _unsafe_getindex, size, axes,
+import Base: +, -, *, /, \, ^, OneTo, getindex, promote_op, _unsafe_getindex, size, axes, length,
             AbstractMatrix, AbstractArray, Matrix, Array, Vector, AbstractVector, Slice,
             show, getproperty, copy, copyto!, map, require_one_based_indexing, similar, inv
 import Base.Broadcast: BroadcastStyle, Broadcasted, broadcasted

src/banded/infbanded.jl

@@ -374,6 +374,7 @@ sub_materialize(::AbstractBandedLayout, V, ::Tuple{InfAxes,OneTo{Int}}) = V
 @inline sub_materialize(::BroadcastBandedLayout, V, ::Tuple{InfAxes,InfAxes}) = V
 @inline sub_materialize(::BandedColumns, V, ::Tuple{InfAxes,InfAxes}) = BandedMatrix(V)
 
+sub_materialize(_, V, ::Tuple{<:BlockedUnitRange{<:InfRanges}}) = V
 
 ##
 # UniformScaling

src/blockbanded/blockbanded.jl

@@ -26,13 +26,16 @@ function BlockArrays.sortedunion(a::Vcat{Int,1,<:Tuple{<:AbstractVector{Int},Inf
 end
 
 sizes_from_blocks(A::AbstractVector, ::Tuple{OneToInf{Int}}) = (map(length,A),)
+length(::BlockedUnitRange{<:InfRanges}) = ℵ₀
 
 const OneToInfBlocks = BlockedUnitRange{OneToInfCumsum}
 const OneToBlocks = BlockedUnitRange{OneToCumsum}
 
 axes(a::OneToInfBlocks) = (a,)
 axes(a::OneToBlocks) = (a,)
 
+LazyBandedMatrices.unitblocks(a::OneToInf) = blockedrange(Ones{Int}(length(a)))
+
 BlockArrays.dimlength(start, ::Infinity) = ℵ₀
 
 function copy(bc::Broadcasted{<:BroadcastStyle,<:Any,typeof(*),<:Tuple{Ones{T,1,Tuple{OneToInfBlocks}},AbstractArray{V,N}}}) where {N,T,V}
@@ -71,9 +74,6 @@ BroadcastStyle(::Type{<:BlockArray{T,N,<:AbstractArray{<:AbstractArray{T,N},N},<
 BroadcastStyle(::Type{<:PseudoBlockArray{T,N,<:AbstractArray{T,N},<:NTuple{N,BlockedUnitRange{<:RangeCumsum{Int,<:InfRanges}}}}}) where {T,N} = LazyArrayStyle{N}()
 
 
-BlockArrays._length(::BlockedUnitRange, ::OneToInf) = ℵ₀
-BlockArrays._last(::BlockedUnitRange, ::OneToInf) = ∞
-
 ###
 # KronTrav
 ###

test/runtests.jl

@@ -2,15 +2,15 @@ using InfiniteLinearAlgebra, BlockBandedMatrices, BlockArrays, BandedMatrices, I
         MatrixFactorizations, ArrayLayouts, LinearAlgebra, Random, LazyBandedMatrices, StaticArrays
 import InfiniteLinearAlgebra: qltail, toeptail, tailiterate , tailiterate!, tail_de, ql_X!,
                     InfToeplitz, PertToeplitz, TriToeplitz, InfBandedMatrix, InfBandCartesianIndices,
-                    rightasymptotics, QLHessenberg, ConstRows, PertConstRows, 
+                    rightasymptotics, QLHessenberg, ConstRows, PertConstRows,
                     BandedToeplitzLayout, PertToeplitzLayout, TridiagonalToeplitzLayout, BidiagonalToeplitzLayout
 import Base: BroadcastStyle
 import BlockArrays: _BlockArray
 import BlockBandedMatrices: isblockbanded, _BlockBandedMatrix
 import MatrixFactorizations: QLPackedQ
 import BandedMatrices: bandeddata, _BandedMatrix, BandedStyle
 import LazyArrays: colsupport, ApplyStyle, MemoryLayout, ApplyLayout, LazyArrayStyle, arguments
-import InfiniteArrays: OneToInf, oneto
+import InfiniteArrays: OneToInf, oneto, RealInfinity
 import LazyBandedMatrices: BroadcastBandedBlockBandedLayout, BroadcastBandedLayout, LazyBandedLayout
 
 
@@ -39,7 +39,7 @@ import LazyBandedMatrices: BroadcastBandedBlockBandedLayout, BroadcastBandedLayo
         @test B*A*x isa Vcat
         @test (B*A*x)[1:10] == [0; 10; 14; 12; zeros(6)]
 
-        @test _BandedMatrix((1:∞)', ∞, -1, 1) isa BandedMatrix 
+        @test _BandedMatrix((1:∞)', ∞, -1, 1) isa BandedMatrix
     end
 
     @testset "∞-Toeplitz" begin
@@ -103,7 +103,7 @@ import LazyBandedMatrices: BroadcastBandedBlockBandedLayout, BroadcastBandedLayo
             @test (A + 2I)[1:10,1:10] == (2I + A)[1:10,1:10] == A[1:10,1:10] + 2I
             @test (Adjoint(A) + 2I)[1:10,1:10] == (2I + Adjoint(A))[1:10,1:10] == Adjoint(A)[1:10,1:10] + 2I
         end
-        
+
 
         @testset "InfBanded" begin
             A = _BandedMatrix(Fill(2,4,∞),ℵ₀,2,1)
@@ -138,7 +138,7 @@ end
         @test blockaxes(b,1) ≡ Block.(OneToInf())
         @test b[Block(5)] == [1,2]
         @test length(axes(b,1)) ≡ ℵ₀
-        @test last(axes(b,1)) ≡ ∞
+        @test last(axes(b,1)) ≡ RealInfinity()
         @test Base.BroadcastStyle(typeof(b)) isa LazyArrayStyle{1}
     end
 
@@ -193,8 +193,8 @@ end
 
     @testset "triangle recurrences" begin
         @testset "n and k" begin
-            n = mortar(Fill.(oneto(∞),oneto(∞)))
-            k = mortar(Base.OneTo.(oneto(∞)))
+            n = mortar(Fill.(oneto(∞),oneto(∞)));
+            k = mortar(Base.OneTo.(oneto(∞)));
 
             @test n[Block(5)] ≡ layout_getindex(n, Block(5)) ≡ view(n,Block(5)) ≡ Fill(5,5)
             @test k[Block(5)] ≡ layout_getindex(k, Block(5)) ≡ view(k,Block(5)) ≡ Base.OneTo(5)
@@ -217,6 +217,11 @@ end
             @test @allocated(axes(v)) ≤ 40
             @test copyto!(dest, v) == v
 
+            @testset "stack overflow" begin
+                i = Base.to_indices(k, (Block.(2:∞),))[1].indices;
+                last(i)
+            end
+
             v = view(k,Block.(2:∞))
             @test Base.BroadcastStyle(typeof(v)) isa LazyArrayStyle{1}
             @test v[Block(1)] == 1:2
@@ -254,7 +259,7 @@ end
             n = mortar(Fill.(oneto(∞),oneto(∞)))
             k = mortar(Base.OneTo.(oneto(∞)))
             Dy = BlockBandedMatrices._BandedBlockBandedMatrix((k .+ (b+c))', axes(k,1), (-1,1), (-1,1))
-            N = 100; 
+            N = 100;
             @test Dy[Block.(1:N), Block.(1:N)] == BlockBandedMatrices._BandedBlockBandedMatrix((k .+ (b+c))[Block.(1:N)]', axes(k,1)[Block.(1:N)], (-1,1), (-1,1))
         end
     end