Skip to content

Commit ede4382

Browse files
committed
Eye ambiguities
1 parent dd49e3a commit ede4382

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/banded/infbanded.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ mulreduce(M::Mul{<:BandedColumns{<:AbstractFillLayout}, BandedToeplitzLayout}) =
441441
mulreduce(M::Mul{BandedToeplitzLayout, <:BandedColumns{<:AbstractFillLayout}}) = ApplyArray(M)
442442
mulreduce(M::Mul{<:AbstractQLayout, BandedToeplitzLayout}) = ApplyArray(M)
443443
mulreduce(M::Mul{<:AbstractQLayout, PertToeplitzLayout}) = ApplyArray(M)
444+
mulreduce(M::Mul{<:DiagonalLayout, BandedToeplitzLayout}) = Lmul(M)
445+
mulreduce(M::Mul{BandedToeplitzLayout, <:DiagonalLayout}) = Rmul(M)
444446

445447

446448
function _bidiag_forwardsub!(M::Ldiv{<:Any,<:PaddedLayout})

test/test_infbanded.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ import BandedMatrices: _BandedMatrix
4545
@test (A * Fill(2,∞))[1:10] 2A[1:10,1:16]*ones(16)
4646
@test (Fill(2,∞,∞)*A)[1:10,1:10] fill(2,10,13)A[1:13,1:10]
4747

48+
@test Eye(∞) * A isa BandedMatrix
49+
@test A * Eye(∞) isa BandedMatrix
50+
4851
@test MemoryLayout(Tridiagonal(Fill(1,∞), Fill(2,∞), Fill(3,∞))) isa TridiagonalToeplitzLayout
4952
@test MemoryLayout(Bidiagonal(Fill(1,∞), Fill(2,∞), :U)) isa BidiagonalToeplitzLayout
5053
@test MemoryLayout(SymTridiagonal(Fill(1,∞), Fill(2,∞))) isa TridiagonalToeplitzLayout
@@ -88,6 +91,9 @@ import BandedMatrices: _BandedMatrix
8891
@test A[2:∞,2:∞] isa PertToeplitz
8992

9093
@test (A + 2I)[1:10,1:10] == (2I + A)[1:10,1:10] == A[1:10,1:10] + 2I
94+
95+
@test Eye(∞) * A isa BandedMatrix
96+
@test A * Eye(∞) isa BandedMatrix
9197
end
9298

9399
@testset "TriPert" begin

0 commit comments

Comments
 (0)