improvements

Author: dkarrasch

src/blockmap.jl

@@ -497,7 +497,7 @@ BlockDiagonalMap(maps::LinearMap...) =
 # since the below methods are more specific than the Base method,
 # they would redefine Base/SparseArrays behavior
 for k in 1:8 # is 8 sufficient?
-    Is = ntuple(n->:($(Symbol(:A, n))::Union{AbstractVecOrMatOrQ}), Val(k-1))
+    Is = ntuple(n->:($(Symbol(:A, n))::AbstractVecOrMatOrQ), Val(k-1))
     # yields (:A1, :A2, :A3, ..., :A(k-1))
     L = :($(Symbol(:A, k))::LinearMap)
     # yields :Ak

src/functionmap.jl

@@ -78,12 +78,12 @@ _ismutating(f) = first(methods(f)).nargs == 3
 const TransposeFunctionMap = TransposeMap{<:Any, <:FunctionMap}
 const AdjointFunctionMap = AdjointMap{<:Any, <:FunctionMap}
 
-function _apply_fun(::Val{true}, f!, x, m, T)
+@inline function _apply_fun(::Val{true}, f!, x, m, T)
     y = similar(x, T, m)
     f!(y, x)
     return y
 end
-function _apply_fun(::Val{false}, f, x, m, _)
+@inline function _apply_fun(::Val{false}, f, x, m, _)
     y = f(x)
     length(y) == m || throw(DimensionMismatch())
     return y

src/linearcombination.jl

@@ -155,7 +155,7 @@ function muladd!(::ThreeArg, y, A, x, α, z)
 end
 
 function Base.:(*)(A::LinearCombination{<:Any,<:Tuple{Vararg{OOPFunctionMap}}}, x::AbstractVector)
-    mapreduce(L -> L * x, (x, y) -> x .+= y, A.maps)
+    mapreduce(L -> L * x, Base.add_sum, A.maps)
 end
 
 _unsafe_mul!(y, A::LinearCombination{<:Any,<:Tuple{Vararg{OOPFunctionMap}}}, x::AbstractVector) =

src/wrappedmap.jl

@@ -23,21 +23,21 @@ WrappedMap(lmap::MapOrVecOrMat{T}; kwargs...) where {T} = WrappedMap{T}(lmap; kw
 
 # cheap property checks (usually by type)
 _issymmetric(A::AbstractMatrix) = false
-_issymmetric(A::LinearAlgebra.AbstractQ) = false
+_issymmetric(A::AbstractQ) = false
 _issymmetric(A::AbstractSparseMatrix) = issymmetric(A)
 _issymmetric(A::LinearMap) = issymmetric(A)
 _issymmetric(A::LinearAlgebra.RealHermSymComplexSym) = issymmetric(A)
 _issymmetric(A::Union{Bidiagonal,Diagonal,SymTridiagonal,Tridiagonal}) = issymmetric(A)
 
 _ishermitian(A::AbstractMatrix) = false
-_ishermitian(A::LinearAlgebra.AbstractQ) = false
+_ishermitian(A::AbstractQ) = false
 _ishermitian(A::AbstractSparseMatrix) = ishermitian(A)
 _ishermitian(A::LinearMap) = ishermitian(A)
 _ishermitian(A::LinearAlgebra.RealHermSymComplexHerm) = ishermitian(A)
 _ishermitian(A::Union{Bidiagonal,Diagonal,SymTridiagonal,Tridiagonal}) = ishermitian(A)
 
 _isposdef(A::AbstractMatrix) = false
-_isposdef(A::LinearAlgebra.AbstractQ) = false
+_isposdef(A::AbstractQ) = false
 _isposdef(A::LinearMap) = isposdef(A)
 
 const VecOrMatMap{T} = WrappedMap{T,<:Union{AbstractVecOrMatOrQ}}