Improve type-stability of tests

Author: timholy

test/fixed.jl

@@ -1,6 +1,13 @@
 using Base.Test
 using FixedPointNumbers
 
+function test_op{F,T}(fun::F, ::Type{T}, fx, fy, fxf, fyf, tol)
+    # Make sure that the result is representable
+    (typemin(T) <= fun(fxf, fyf) <= typemax(T)) || return nothing
+    @test abs(fun(fx, fy) - convert(T, fun(fxf, fyf))) <= tol
+    @test abs(convert(Float64, fun(fx, fy)) - fun(fxf, fyf)) <= tol
+end
+
 function test_fixed{T}(::Type{T}, f)
     values = [-10:0.01:10; -180:.01:-160; 160:.01:180]
     tol = 2.0^-f
@@ -33,15 +40,10 @@ function test_fixed{T}(::Type{T}, f)
             @test fx<fy  || x>=y
             @test fx<=fy || x>y
 
-            for fun in (+, -, *, /)
-                # Make sure that the result is representable
-                if !(typemin(T) <= fun(fxf, fyf) <= typemax(T))
-                    continue
-                elseif (fun == /) && fy != 0
-                    @test abs(fun(fx, fy) - convert(T, fun(fxf, fyf))) <= tol
-                    @test abs(convert(Float64, fun(fx, fy)) - fun(fxf, fyf)) <= tol
-                end
-            end
+            test_op(+, T, fx, fy, fxf, fyf, tol)
+            test_op(-, T, fx, fy, fxf, fyf, tol)
+            test_op(*, T, fx, fy, fxf, fyf, tol)
+            fy != 0 && test_op(/, T, fx, fy, fxf, fyf, tol)
 
             @test isequal(fx,fy) == isequal(hash(fx),hash(fy))
         end