Fix % Normed{UInt32} on ARM

This also adds tests for `NaN`/`Inf`.
This clarifies the behavior regarding `NaN` and `Inf`, which had not been explicitly defined.

Author: kimikage

src/utilities.jl

@@ -45,7 +45,11 @@ _unsafe_trunc(::Type{T}, x::BigFloat) where {T <: Integer} = trunc(BigInt, x) %
 if !signbit(signed(unsafe_trunc(UInt, -12.345)))
     # a workaround for ARM (issue #134)
     function _unsafe_trunc(::Type{T}, x::AbstractFloat) where {T <: Integer}
-        unsafe_trunc(T, unsafe_trunc(signedtype(T), x))
+        if T === UInt32
+            copysign(unsafe_trunc(T, abs(x)), x)
+        else
+            unsafe_trunc(T, unsafe_trunc(signedtype(T), x))
+        end
     end
 end
 

test/fixed.jl

@@ -219,6 +219,14 @@ end
     end
 end
 
+@testset "conversions from float" begin
+    @testset "$F(nan)" for F in target(Fixed; ex = :thin)
+        @test_throws ArgumentError F(Inf)
+        @test_throws ArgumentError F(-Inf32)
+        @test_throws ArgumentError F(NaN)
+    end
+end
+
 @testset "conversions to float" begin
     for T in (Float16, Float32, Float64)
         @test isa(convert(T, Q0f7(0.3)), T)
@@ -283,6 +291,11 @@ end
 
     @test -1 % Q0f7 === Q0f7(-1)
     @test -2 % Q0f7 === Q0f7(0)
+
+    # TODO: avoid undefined behavior
+    @testset "nan % $F" for F in target(Fixed, :i8, :i16, :i32; ex = :thin)
+        @test NaN % F === NaN32 % F === NaN16 % F === zero(F)
+    end
 end
 
 @testset "neg" begin
@@ -497,6 +510,12 @@ end
     @test clamp(0.5,     Q0f7) === 0.5Q0f7
     @test clamp(-1.5f0,  Q0f7) === -1.0Q0f7
     @test clamp(1.5Q1f6, Q0f7) === 0.992Q0f7
+
+    @testset "clamp(nan, $F)" for F in target(Fixed; ex = :thin)
+        @test clamp( Inf, F) === clamp( Inf32, F) === typemax(F)
+        @test clamp(-Inf, F) === clamp(-Inf32, F) === typemin(F)
+        @test clamp( NaN, F) === clamp( NaN32, F) === zero(F)
+    end
 end
 
 @testset "sign-related functions" begin

test/normed.jl

@@ -184,7 +184,7 @@ end
     end
 end
 
-@testset "conversion from float" begin
+@testset "conversions from float" begin
     # issue 102
     for Tf in (Float16, Float32, Float64)
         @testset "$N(::$Tf)" for N in target(Normed)
@@ -213,6 +213,12 @@ end
     @test N0f32(Float32(0x0.7FFFFFp-32)) == zero(N0f32)
     @test N0f32(Float32(0x0.800000p-32)) <= eps(N0f32) # should be zero in RoundNearest mode
     @test N0f32(Float32(0x0.800001p-32)) == eps(N0f32)
+
+    @testset "$N(nan)" for N in target(Normed; ex = :thin)
+        @test_throws ArgumentError N(Inf)
+        @test_throws ArgumentError N(-Inf32)
+        @test_throws ArgumentError N(NaN)
+    end
 end
 
 @testset "conversions to float" begin
@@ -275,9 +281,14 @@ end
     @test all(f -> 1.0f0 % Normed{UInt32,f} == oneunit(Normed{UInt32,f}), 1:32)
     @test all(f -> 1.0e0 % Normed{UInt64,f} == oneunit(Normed{UInt64,f}), 1:64)
 
-    # issu #211
+    # issue #211
     @test big"1.2" % N0f8 === 0.196N0f8
     @test reinterpret(BigFloat(0x0_01234567_89abcdef) % N63f1) === 0x01234567_89abcdef
+
+    # TODO: avoid undefined behavior
+    @testset "nan % $N" for N in target(Normed, :i8, :i16, :i32; ex = :thin)
+        @test NaN % N === NaN32 % N === zero(N)
+    end
 end
 
 @testset "arithmetic" begin
@@ -506,6 +517,12 @@ end
     @test clamp(0.5,     N0f8) === 0.5N0f8
     @test clamp(-1.0f0,  N0f8) === 0.0N0f8
     @test clamp(2.0N1f7, N0f8) === 1.0N0f8
+
+    @testset "clamp(nan, $N)" for N in target(Normed; ex = :thin)
+        @test clamp( Inf, N) === clamp( Inf32, N) === typemax(N)
+        @test clamp(-Inf, N) === clamp(-Inf32, N) === typemin(N)
+        @test clamp( NaN, N) === clamp( NaN32, N) === zero(N)
+    end
 end
 
 @testset "sign-related functions" begin