Skip to content

fix tests on 1.7 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 2, 2021
Merged

fix tests on 1.7 #253

merged 6 commits into from
Aug 2, 2021

Conversation

KristofferC
Copy link
Member

No description provided.

johnnychen94
johnnychen94 reviewed Aug 2, 2021
View reviewed changes
@KristofferC @johnnychen94
Update test/runtests.jl
05ed82a 
Co-authored-by: Johnny Chen <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #253 (f62e917) into master (277a3e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files           6        6           
  Lines         731      731           
=======================================
  Hits          679      679           
  Misses         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277a3e4...f62e917. Read the comment docs.

@kimikage
Copy link
Collaborator

kimikage commented Aug 2, 2021

I'm confused because unsafe_length is "unchecked" and checked_length is "checked".

kimikage
kimikage reviewed Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@kimikage kimikage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is enough to simply check the overflow. Also, isn't 1.7 in the title a mistake for 1.8-DEV?

@KristofferC
Copy link
Member Author

Also, isn't 1.7 in the title a mistake for 1.8-DEV?

No, because the relevant changes are on the backport branch.

kimikage
kimikage reviewed Aug 2, 2021
View reviewed changes
@kimikage
Copy link
Collaborator

kimikage commented Aug 2, 2021

The segmentation fault on aarch64 nightly is strange, but at least it's not related to this PR.

@kimikage kimikage merged commit fbc8ef7 into JuliaMath:master Aug 2, 2021
@KristofferC KristofferC deleted the kc/fix branch August 3, 2021 09:52
@kimikage kimikage mentioned this pull request Apr 30, 2024
Closed
38 tasks
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
a87b5ad 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
a79b0f2 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
ca863b5 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
b02837d 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
9361f3f 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
766ba23 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
acd2fad 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
3149fb6 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 13, 2024
@johnnychen94 @kimikage
fix tests on 1.7 (JuliaMath#253)
dbd1870 
Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>
kimikage added a commit that referenced this pull request May 13, 2024
@kimikage @johnnychen94
Update tests (#300)
a995a9d 
* Backport "Fix test for exponentially growing `promote_type` (#280)"

* fix tests on 1.7 (#253)

Co-authored-by: Johnny Chen <[email protected]>
Co-authored-by: kimikage <[email protected]>

* Mark `test_broken` for conversion to `Float16`

* Backport "Add test for `unsafe_trunc` returning arbitrary values (#289)"

---------

Co-authored-by: Kristoffer Carlsson <[email protected]>
Co-authored-by: Johnny Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 left review comments

@kimikage kimikage kimikage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @kimikage @johnnychen94