Skip to content

Revert "Work around inference failure in promotion on nightly" #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kimikage
Copy link
Collaborator

Reverts #249

It has been more than 2 years since the release of Julia v1.7 and it looks fine without @pure.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (3a4346c) to head (ca32586).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files           7        7           
  Lines         784      784           
=======================================
  Hits          760      760           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimikage kimikage marked this pull request as ready for review April 30, 2024 07:18
@kimikage kimikage merged commit cb1efdd into master Apr 30, 2024
@kimikage kimikage deleted the revert-249-infer_promotion branch April 30, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant