Skip to content

Use widening to reliably throw InexactErrors #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2016
Merged

Use widening to reliably throw InexactErrors #48

merged 4 commits into from
Sep 14, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 14, 2016

It turns out we still have the behavior described in #21 and #37. Hopefully this PR fixes those issues.

Since this is a change in behavior, I suspect the next tag should be a minor increment (even though @vchuravy and @bjarthur have contributed much more "fundamental" changes, at least their changes were non-breaking). Consequently, now might be a good time to consider other disruptive changes. I therefore also deprecated the lowercase conversion functions ufixed8. I'll probably also work on trying to come up with a more compact printing syntax before we tag.

@timholy
Copy link
Member Author

timholy commented Sep 14, 2016

@JeffBezanson, it looks like you're the only one with "admin" privileges. Can you please turn on the Appveyor webook? I'm hoping to find out whether #15 is still an issue.

@bjarthur
Copy link
Collaborator

need to take ufixed12 out of the README

@timholy
Copy link
Member Author

timholy commented Sep 14, 2016

Done. I took the opportunity to expand the amount of explanation about the meaning of these numbers. Had we done this earlier, it might have saved @vchuravy a certain amount of suffering (#32).

@vchuravy
Copy link
Collaborator

These changes look great and the additional explanations helps a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants