You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am not sure to fully understand the naming conventions, but the actual code uses the input types to detect the function prefix (like _vmld, _vmlz). This works for most functions (that have the same input and output types), but not for CIS, which takes reals and returns complex numbers, but is defined as _vmlcCIS and _vlczCIS. I don't think we should use the output type instead, given that Arg (angle) does the opposite (complex->float, but also defined as _vmlcArg and _vmlzArg).
So I don't know what is the cleanest way to solve this case, but using a different prefix just for CIS does solve the problem. Sorry I'm not sure how to make a clean pull request as I already cloned the repo from the v0.7 PR, that has not been merged yet.
The text was updated successfully, but these errors were encountered:
I looked into this, unfortunately this is not consistent within VML, so it is not as easy as just picking the VML function based on output instead of input type.
Happy to put your solution in.
Hi, I am not sure to fully understand the naming conventions, but the actual code uses the input types to detect the function prefix (like _vmld, _vmlz). This works for most functions (that have the same input and output types), but not for
CIS
, which takes reals and returns complex numbers, but is defined as_vmlcCIS
and_vlczCIS
. I don't think we should use the output type instead, given thatArg
(angle
) does the opposite (complex->float, but also defined as_vmlcArg
and_vmlzArg
).So I don't know what is the cleanest way to solve this case, but using a different prefix just for
CIS
does solve the problem. Sorry I'm not sure how to make a clean pull request as I already cloned the repo from the v0.7 PR, that has not been merged yet.The text was updated successfully, but these errors were encountered: