Skip to content

Wrong linking for the CIS function #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Djoop opened this issue Feb 2, 2019 · 3 comments
Closed

Wrong linking for the CIS function #15

Djoop opened this issue Feb 2, 2019 · 3 comments

Comments

@Djoop
Copy link

Djoop commented Feb 2, 2019

Hi, I am not sure to fully understand the naming conventions, but the actual code uses the input types to detect the function prefix (like _vmld, _vmlz). This works for most functions (that have the same input and output types), but not for CIS, which takes reals and returns complex numbers, but is defined as _vmlcCIS and _vlczCIS. I don't think we should use the output type instead, given that Arg (angle) does the opposite (complex->float, but also defined as _vmlcArg and _vmlzArg).
So I don't know what is the cleanest way to solve this case, but using a different prefix just for CIS does solve the problem. Sorry I'm not sure how to make a clean pull request as I already cloned the repo from the v0.7 PR, that has not been merged yet.

@Crown421
Copy link
Collaborator

I looked into this, unfortunately this is not consistent within VML, so it is not as easy as just picking the VML function based on output instead of input type.
Happy to put your solution in.

@Crown421
Copy link
Collaborator

Pull request #17 now contains CIS.

@aminya
Copy link
Member

aminya commented Nov 26, 2019

Closed by #17

@aminya aminya closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants