Skip to content

lgamma is deprecated to logabsgamma #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminya opened this issue Nov 23, 2019 · 3 comments
Closed

lgamma is deprecated to logabsgamma #20

aminya opened this issue Nov 23, 2019 · 3 comments
Milestone

Comments

@aminya
Copy link
Member

aminya commented Nov 23, 2019

In the Julia 1 branch (#17) or once it is merged,
we should address this.

https://github.com/JuliaMath/SpecialFunctions.jl/blob/master/src/deprecated.jl#L1

@Crown421
Copy link
Collaborator

I am not sure how we would do that?
The function that VML provides is lgamma and I don't see nice way and a good reason to force some VML.logabsgamma(a)[1] syntax.
What should be changed is the use of Base.lgamma in the tests, which might require special treatment.

@aminya
Copy link
Member Author

aminya commented Nov 26, 2019

Maybe we can just wrap VML.lgamma in some function to provide VML.logabsgamma(a)[1]

https://github.com/JuliaMath/SpecialFunctions.jl/blob/61f9058fbc3428eb8894a57e4f5a2c0217b3e439/src/gamma.jl#L604

We can have both. There is no reason to deprecate lgamma

@Crown421
Copy link
Collaborator

Crown421 commented Jan 3, 2023

The deprecation warnings in tests have been removed in #60 . I don't see further need for changes here, as we can continue to have IVM.lgamma

@Crown421 Crown421 closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants