-
Notifications
You must be signed in to change notification settings - Fork 18
Setting mode during precompilation time doesn't make sense #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The call to the init function is now no longer necessary with #39, as no Regarding the other point I believe you are correct, it seems redundant. I am not even sure what the command is trying to accomplish, especially given that a more convenient function using integer input is defined just above it. |
Yeah, my point is mostly about the call to set the mode during compilation time. It doesn't do anything. |
I will remove it, and have quick look as to whether there might need to be call on |
This is part of #39 now. |
Calling
__init__
here: https://github.com/JuliaMath/IntelVectorMath.jl/blob/master/src/setup.jl#L11and then setting the mode here:
https://github.com/JuliaMath/IntelVectorMath.jl/blob/master/src/setup.jl#L32
doesn't look like it will work properly. The mode is a property of the MKL library and will not be kept when the package is reloaded. If it needs to be set when the package is started, it should be set in
__init__
itself.The text was updated successfully, but these errors were encountered: