-
Notifications
You must be signed in to change notification settings - Fork 18
Add support for CdfNorm #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, very glad you like this package. I think that should be doable, you mean this function, correct? |
Oh cool! That's the function I mean, yes. |
Sorry that it took me a while, I made an MR and should have it merged by the end of the day. From my (not very rigorous) tests, it seems to be faster than going via |
Thanks Steffan that's great, it looks like there was an issue with the MacOS/Julia nightlies which prevented the merge, but I'll give it a go once it's merged and let you know how it performs in my code. Happy to do some comparisons for the README if that's useful - I don't think Base has a |
There was an issue with the tagbot, which only got fixed today. Will hopefully merge later today. |
Ok, it is done, merged, and registered. |
Hi,
Great package, thanks for making it, it's sped up my code considerably.
I'm aware this would probably come under the "if there's enough interest" category, but would it be possible to add support for VML's CdfNorm function? It's not urgent as we can just use the relation to erf() instead, but it'd be interesting to see if using the dedicated function is faster. I would offer to give it a go myself, but I'm not sure I have the chops.
Cheers
The text was updated successfully, but these errors were encountered: