Skip to content

Some updates for IntelVectorMath.jl #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2023
Merged

Conversation

ylvain
Copy link
Contributor

@ylvain ylvain commented Jun 8, 2022

I needed VML but stumbled on 2 problems with the current release 0.4.1

  • The compat section reference MKL_jll 2020 and 2021, but MKL.jl use 2021, 2022. This was downgrading my MKL.
  • In my use case, I need to handle threading myself and so I want VML to execute in a single thread.

The commits below fixe these issues. As I was at it I added control for denormal handling, tests, and a README update.

  1. Change the compat to MKL 2021, 2022. This is what MKL.jl use on the current release 0.5.0
  2. Add get/set for denormal mode handling and number of threads (impacting only VML, not BLAS/LAPACK etc.)
  3. Version bump from 0.4.1 to 0.4.2.
  4. Tests for the get/set, mention of these functions in the README.

@ylvain
Copy link
Contributor Author

ylvain commented Jun 8, 2022

Hum... I notice only now that the other pending pull requests #54 actually has a commit for get/set numthreads... well... missed it, does not appear in the title/text, my bad. Anyway, mine as a doc-string :)

@Crown421
Copy link
Collaborator

Crown421 commented Jan 1, 2023

My apologies, I was quite distracted last year. Currently looking through it, but seems quite solid.

Copy link
Collaborator

@Crown421 Crown421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great documentation.

@Crown421 Crown421 merged commit 4222853 into JuliaMath:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants