Issue 403c (#419)

* avoid invalidation; warning with v1.8

* push off warning removal for another day

Author: jverzani

src/common.jl

@@ -897,6 +897,7 @@ end
 
     return quote
         Base.@_inline_meta
+        #Base.@inline
         tuple($(exprs...))
     end
 

src/polynomials/ImmutablePolynomial.jl

@@ -240,7 +240,8 @@ LinearAlgebra.norm(q::ImmutablePolynomial, p::Real) = _norm(q.coeffs, p)
     end
 
     return quote
-        $(Expr(:meta, :inline))
+        $(Expr(:meta, :inline)) # 1.8 deprecation
+        #Base.@inline
         @inbounds return sqrt($expr)
     end
 
@@ -259,7 +260,8 @@ _norm_p0(x) = iszero(x) ? zero(x) : one(x)
     end
 
     return quote
-        $(Expr(:meta, :inline))
+        $(Expr(:meta, :inline)) # 1.8 deprecation
+        #Base.@inline
         if p == Inf
             return mapreduce(abs, max, a)
         elseif p == 1

src/polynomials/pi_n_polynomial.jl

@@ -28,7 +28,10 @@ Polynomials.@register PnPolynomial
 # change broadcast semantics
 Base.broadcastable(p::PnPolynomial) = p.coeffs;
 Base.ndims(::Type{<:PnPolynomial}) = 1
-Base.copyto!(p::PnPolynomial, x) = copyto!(p.coeffs, x);
+Base.copyto!(p::PnPolynomial{T, X}, x::S) where
+{T, X,
+ S<:Union{AbstractVector, Base.AbstractBroadcasted, Tuple} # to avoid an invalidation. Might need to be more general?
+ } = copyto!(p.coeffs, x)
 
 function Polynomials.degree(p::PnPolynomial)
     i = findlast(!iszero, p.coeffs)
@@ -43,9 +46,8 @@ function LinearAlgebra.mul!(pq, p::PnPolynomial{T,X}, q) where {T,X}
     for i ∈ 0:m
         for j ∈ 0:n
             k = i + j
-            pq.coeffs[1+k] += p.coeffs[1+i] * q.coeffs[1+j]
+            @inbounds pq.coeffs[1+k] += p.coeffs[1+i] * q.coeffs[1+j]
         end
     end
     nothing
 end
-

src/polynomials/standard-basis.jl

@@ -125,7 +125,7 @@ end
     end
 
     return quote
-        Base.@_inline_meta
+        Base.@_inline_meta # 1.8 deprecation
         tuple($(exprs...))
     end