Skip to content

Commit 36cff17

Browse files
committed
use bsdtar from LibArchive_jll
1 parent 6f0b7f5 commit 36cff17

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

Project.toml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
name = "ArcadeLearningEnvironment"
22
uuid = "b7f77d8d-088d-5e02-8ac0-89aab2acc977"
3-
version = "0.2.2"
3+
version = "0.2.3"
44

55
[deps]
66
ArcadeLearningEnvironment_jll = "52cbb755-00ff-5a24-b23e-8a91c598877e"
7+
LibArchive_jll = "1e303b3e-d4db-56ce-88c4-91e52606a1a8"
78
MD5 = "6ac74813-4b46-53a4-afec-0b5dc9d7885c"
89
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
910

1011
[compat]
11-
julia = "1.4"
12-
MD5 = "0.2"
1312
ArcadeLearningEnvironment_jll = "0.6"
13+
LibArchive_jll = "3"
14+
MD5 = "0.2"
15+
julia = "1.3, 1.4"
1416

1517
[extras]
1618
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ paper to acknowledge the work that went into ALE.
3636
## Installation
3737

3838
The package automatically downloads version 0.6.1 of the ArcadeLearningEnvironment
39+
and the ROMS from www.atarimania.com.
3940

4041
```julia
4142
Pkg.add("ArcadeLearningEnvironment")
@@ -47,6 +48,7 @@ Pkg.add("ArcadeLearningEnvironment")
4748
```julia
4849
using ArcadeLearningEnvironment
4950

51+
getROMList()
5052

5153
episodes = 50
5254

deps/build.jl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using MD5
2+
using LibArchive_jll
23
using Pkg.Artifacts
34

45
function import_roms(dir)
@@ -36,8 +37,10 @@ if rom_hash == nothing || !artifact_exists(rom_hash)
3637
download("https://raw.githubusercontent.com/mgbellemare/Arcade-Learning-Environment/v0.6.1/md5.txt", joinpath(artifact_dir, "md5.txt"))
3738
download("http://www.atarimania.com/roms/Roms.rar", joinpath(artifact_dir, "Roms.rar"))
3839
cd(artifact_dir)
39-
run(`7z e $(joinpath(artifact_dir, "Roms.rar"))`)
40-
run(`7z x $(joinpath(artifact_dir, "ROMS.zip"))`)
40+
bsdtar() do exe
41+
run(`$exe -xf $(joinpath(artifact_dir, "Roms.rar"))`)
42+
run(`$exe -xf $(joinpath(artifact_dir, "ROMS.zip"))`)
43+
end
4144
rm(joinpath(artifact_dir, "Roms.rar"))
4245
rm(joinpath(artifact_dir, "ROMS.zip"))
4346
rm(joinpath(artifact_dir, "HC ROMS.zip"))

0 commit comments

Comments
 (0)